mash: Support ShelfWindowWatcher via ShelfItem properties.

ash/aura/wm_window_aura.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/aura/wm_window_aura.h"
 
 #include "ash/aura/aura_layout_manager_adapter.h"
 #include "ash/aura/wm_root_window_controller_aura.h"
 #include "ash/aura/wm_shell_aura.h"
 #include "ash/common/ash_constants.h"
@@ skipping 27 matching lines @@
 #include "ui/display/screen.h"
 #include "ui/gfx/geometry/insets.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 #include "ui/wm/core/coordinate_conversion.h"
 #include "ui/wm/core/easy_resize_window_targeter.h"
 #include "ui/wm/core/transient_window_manager.h"
 #include "ui/wm/core/visibility_controller.h"
 #include "ui/wm/core/window_util.h"
 
-DECLARE_WINDOW_PROPERTY_TYPE(ash::ShelfItemDetails*);
 DECLARE_WINDOW_PROPERTY_TYPE(ash::WmWindowAura*);
 
 namespace ash {
 
 DEFINE_WINDOW_PROPERTY_KEY(ShelfID, kShelfIDKey, kInvalidShelfID);
+DEFINE_WINDOW_PROPERTY_KEY(int, kShelfItemTypeKey, TYPE_UNDEFINED);
+DEFINE_WINDOW_PROPERTY_KEY(int, kShelfIconIdKey, kInvalidImageResourceID);

[James Cook, 2016/09/28 20:41:03]

So on aura, GetWindowProperty(kShelfIconIdKey) for a window with no property set
will return an invalid resource id, whereas on mus it will return a default icon
id? Is that intentional?

[msw, 2016/09/28 23:27:46]

Yes, for now mash relies on ShelfWindowWatcher for *all* windows, that might
change in the very near future, but for now, it seems beneficial.

 
-DEFINE_OWNED_WINDOW_PROPERTY_KEY(ShelfItemDetails,
-                                 kShelfItemDetailsKey,
-                                 nullptr);
 DEFINE_OWNED_WINDOW_PROPERTY_KEY(WmWindowAura, kWmWindowKey, nullptr);
 
 static_assert(aura::Window::kInitialId == kShellWindowId_Invalid,
               "ids must match");
 
 namespace {
 
 // A tentative class to set the bounds on the window.
 // TODO(oshima): Once all logic is cleaned up, move this to the real layout
 // manager with proper friendship.
@@ skipping 93 matching lines @@
 }
 
 void WmWindowAura::SetName(const char* name) {
   window_->SetName(name);
 }
 
 std::string WmWindowAura::GetName() const {
   return window_->name();
 }
 
+void WmWindowAura::SetTitle(const base::string16& title) {
+  window_->SetTitle(title);
+}
+
 base::string16 WmWindowAura::GetTitle() const {
   return window_->title();
 }
 
 void WmWindowAura::SetShellWindowId(int id) {
   window_->set_id(id);
 }
 
 int WmWindowAura::GetShellWindowId() const {
   return window_->id();
@@ skipping 128 matching lines @@
     return;
   }
 
   NOTREACHED();
 }
 
 int WmWindowAura::GetIntProperty(WmWindowProperty key) {
   if (key == WmWindowProperty::MODAL_TYPE)
     return window_->GetProperty(aura::client::kModalKey);
 
+  if (key == WmWindowProperty::SHELF_ICON_ID)
+    return window_->GetProperty(kShelfIconIdKey);
+
   if (key == WmWindowProperty::SHELF_ID)
     return window_->GetProperty(kShelfIDKey);
 
+  if (key == WmWindowProperty::SHELF_ITEM_TYPE)
+    return window_->GetProperty(kShelfItemTypeKey);
+
   if (key == WmWindowProperty::TOP_VIEW_INSET)
     return window_->GetProperty(aura::client::kTopViewInset);
 
   NOTREACHED();
   return 0;
 }
 
 void WmWindowAura::SetIntProperty(WmWindowProperty key, int value) {
+  if (key == WmWindowProperty::SHELF_ICON_ID) {
+    window_->SetProperty(kShelfIconIdKey, value);
+    return;
+  }
   if (key == WmWindowProperty::SHELF_ID) {
     window_->SetProperty(kShelfIDKey, value);
     return;
   }
+  if (key == WmWindowProperty::SHELF_ITEM_TYPE) {
+    window_->SetProperty(kShelfItemTypeKey, value);
+    return;
+  }
   if (key == WmWindowProperty::TOP_VIEW_INSET) {
     window_->SetProperty(aura::client::kTopViewInset, value);
     return;
   }
 
   NOTREACHED();
 }
 
-ShelfItemDetails* WmWindowAura::GetShelfItemDetails() {
-  return window_->GetProperty(kShelfItemDetailsKey);
-}
-
-void WmWindowAura::SetShelfItemDetails(const ShelfItemDetails& details) {
-  // |item_details| is owned by |window_|.
-  ShelfItemDetails* item_details = new ShelfItemDetails(details);
-  window_->SetProperty(kShelfItemDetailsKey, item_details);
-}
-
-void WmWindowAura::ClearShelfItemDetails() {
-  window_->ClearProperty(kShelfItemDetailsKey);
-}
-
 const wm::WindowState* WmWindowAura::GetWindowState() const {
   return ash::wm::GetWindowState(window_);
 }
 
 WmWindow* WmWindowAura::GetToplevelWindow() {
   return Get(window_->GetToplevelWindow());
 }
 
 WmWindow* WmWindowAura::GetToplevelWindowForFocus() {
   return Get(::wm::GetToplevelWindow(window_));
@@ skipping 445 matching lines @@
     ash::wm::GetWindowState(window_)->OnWindowShowStateChanged();
     return;
   }
   WmWindowProperty wm_property;
   if (key == aura::client::kAlwaysOnTopKey) {
     wm_property = WmWindowProperty::ALWAYS_ON_TOP;
   } else if (key == aura::client::kExcludeFromMruKey) {
     wm_property = WmWindowProperty::EXCLUDE_FROM_MRU;
   } else if (key == aura::client::kModalKey) {
     wm_property = WmWindowProperty::MODAL_TYPE;
+  } else if (key == kShelfIconIdKey) {
+    wm_property = WmWindowProperty::SHELF_ICON_ID;
   } else if (key == kShelfIDKey) {
     wm_property = WmWindowProperty::SHELF_ID;
-  } else if (key == kShelfItemDetailsKey) {
-    wm_property = WmWindowProperty::SHELF_ITEM_DETAILS;
+  } else if (key == kShelfItemTypeKey) {
+    wm_property = WmWindowProperty::SHELF_ITEM_TYPE;
   } else if (key == kSnapChildrenToPixelBoundary) {
     wm_property = WmWindowProperty::SNAP_CHILDREN_TO_PIXEL_BOUNDARY;
   } else if (key == aura::client::kTopViewInset) {
     wm_property = WmWindowProperty::TOP_VIEW_INSET;
   } else {
     return;
   }
   FOR_EACH_OBSERVER(WmWindowObserver, observers_,
                     OnWindowPropertyChanged(this, wm_property));
 }
@@ skipping 35 matching lines @@
                     OnTransientChildAdded(this, Get(transient)));
 }
 
 void WmWindowAura::OnTransientChildRemoved(aura::Window* window,
                                            aura::Window* transient) {
   FOR_EACH_OBSERVER(WmTransientWindowObserver, transient_observers_,
                     OnTransientChildRemoved(this, Get(transient)));
 }
 
 }  // namespace ash