Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/IceInstMIPS32.h

Issue 2357143002: [SubZero] Fix floating-point comparison for MIPS (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstMIPS32.h
diff --git a/src/IceInstMIPS32.h b/src/IceInstMIPS32.h
index 0f3037858374252bad8a3326eb2b3cfd870478d1..bfb19be9383a54d54e947ed2f8aa9148b9f09a69 100644
--- a/src/IceInstMIPS32.h
+++ b/src/IceInstMIPS32.h
@@ -95,8 +95,10 @@ public:
}
void dump(const Cfg *Func, Ostream &Str) const override {
+ if (!BuildDefs::dump())
+ return;
(void)Func;
- (void)Str;
+ Str << "$fcc" << static_cast<uint16_t>(FpCondCode);
}
private:
@@ -1062,13 +1064,13 @@ public:
if (!BuildDefs::dump())
return;
Ostream &Str = Func->getContext()->getStrEmit();
- assert(getSrcSize() == 2);
+ assert(getSrcSize() == 3);
Str << "\t" << Opcode << "\t";
getDest()->emit(Func);
Str << ", ";
- getSrc(0)->emit(Func);
- Str << ", ";
getSrc(1)->emit(Func);
+ Str << ", ";
+ getSrc(2)->emit(Func);
}
void emitIAS(const Cfg *Func) const override {
@@ -1091,7 +1093,8 @@ public:
private:
InstMIPS32MovConditional(Cfg *Func, Variable *Dest, Variable *Src,
Operand *FCC)
- : InstMIPS32(Func, K, 2, Dest) {
+ : InstMIPS32(Func, K, 3, Dest) {
+ addSource(Dest);
addSource(Src);
addSource(FCC);
}
« no previous file with comments | « src/IceAssemblerMIPS32.cpp ('k') | src/IceInstMIPS32.cpp » ('j') | src/IceTargetLoweringMIPS32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698