Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 23571006: drive: Stop using resource ID to access local metadata in CreateDirectoryOperation (Closed)

Created:
7 years, 3 months ago by hashimoto
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, oshima+watch_chromium.org, tfarina, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Stop using resource ID to access local metadata in CreateDirectoryOperation Rename ResourceMetadata::GetChildResourceId to GetChildId BUG=275270 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M chrome/browser/chromeos/drive/file_system/create_directory_operation.cc View 4 chunks +23 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
7 years, 3 months ago (2013-08-30 05:26:31 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-08-30 05:29:14 UTC) #2
hashimoto
7 years, 3 months ago (2013-08-30 07:17:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r220528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698