Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2357093002: Polymer WebUI: Remove app-route from Polymer components (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polymer WebUI: Remove app-route from Polymer components MD History, which was the only user of this element, moved away from it in https://codereview.chromium.org/2352293002/. It can now be safely removed from the binary and repository. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8739bc4bcb3659b6c4dc4b88e88e246581f70363 Cr-Commit-Position: refs/heads/master@{#421148}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -850 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-location.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-location-extracted.js View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-route.html View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-route-converter.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-route-converter-behavior.html View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-route-converter-behavior-extracted.js View 1 chunk +0 lines, -99 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-route-converter-extracted.js View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/app-route-extracted.js View 1 chunk +0 lines, -319 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/bower.json View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/app-route/compiled_resources2.gyp View 1 chunk +0 lines, -33 lines 0 comments Download
M third_party/polymer/v1_0/find_unused_elements.py View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 chunk +0 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (12 generated)
tsergeant
PTAL. This is the follow-up to https://codereview.chromium.org/2352293002/
4 years, 3 months ago (2016-09-23 05:02:08 UTC) #3
Dan Beam
lgtm
4 years, 3 months ago (2016-09-23 05:52:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357093002/20001
4 years, 2 months ago (2016-09-25 22:50:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147692)
4 years, 2 months ago (2016-09-26 00:16:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357093002/20001
4 years, 2 months ago (2016-09-26 01:16:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147722)
4 years, 2 months ago (2016-09-26 04:00:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357093002/20001
4 years, 2 months ago (2016-09-27 00:03:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148675)
4 years, 2 months ago (2016-09-27 03:09:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357093002/20001
4 years, 2 months ago (2016-09-27 03:17:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/286885)
4 years, 2 months ago (2016-09-27 04:06:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357093002/20001
4 years, 2 months ago (2016-09-27 06:46:52 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-27 08:40:31 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 08:42:25 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8739bc4bcb3659b6c4dc4b88e88e246581f70363
Cr-Commit-Position: refs/heads/master@{#421148}

Powered by Google App Engine
This is Rietveld 408576698