Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Issue 2357083002: bluetooth: Leak connections to paired devices (Closed)

Created:
4 years, 3 months ago by ortuno
Modified:
4 years, 2 months ago
Reviewers:
scheib
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Leak connections to paired devices In order to avoid terminating connection to devices other parts of the system might still be using we leak connections to paired devices. BUG=630586 Committed: https://crrev.com/f1da372348cf570d8f1bb538b16d0ec3d47fbeb3 Cr-Commit-Position: refs/heads/master@{#420865}

Patch Set 1 #

Patch Set 2 : bluetooth: Leak connections to paired devices #

Patch Set 3 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M device/bluetooth/bluetooth_device.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_device_bluez.cc View 1 2 2 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
ortuno
scheib: PTAL
4 years, 3 months ago (2016-09-21 08:02:49 UTC) #2
scheib
LGTM. Try jobs point out tests need updating.
4 years, 3 months ago (2016-09-21 18:03:02 UTC) #7
ortuno
scheib: Turns out there was a bit more to this. PTAL again.
4 years, 3 months ago (2016-09-23 12:04:04 UTC) #8
scheib
LGTM
4 years, 3 months ago (2016-09-23 22:57:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357083002/40001
4 years, 2 months ago (2016-09-25 06:01:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/285729)
4 years, 2 months ago (2016-09-25 06:56:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357083002/40001
4 years, 2 months ago (2016-09-25 10:51:28 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/285743)
4 years, 2 months ago (2016-09-25 11:35:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357083002/40001
4 years, 2 months ago (2016-09-25 12:00:33 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/299309)
4 years, 2 months ago (2016-09-25 15:29:37 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357083002/40001
4 years, 2 months ago (2016-09-25 23:20:09 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-26 00:41:30 UTC) #28
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 00:44:01 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f1da372348cf570d8f1bb538b16d0ec3d47fbeb3
Cr-Commit-Position: refs/heads/master@{#420865}

Powered by Google App Engine
This is Rietveld 408576698