components/arc/ime/arc_ime_bridge_impl.cc - Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/ime/arc_ime_bridge_impl.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)

Patch Set: Address comments from Luis Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/ime/arc_ime_bridge_impl.cc

diff --git a/components/arc/ime/arc_ime_bridge_impl.cc b/components/arc/ime/arc_ime_bridge_impl.cc

index 4f75aed8fb25791b2beab816e77ac2e6502688fc..03a6dc2c5ef8c7df2be725bd9c242e8330715d34 100644

--- a/components/arc/ime/arc_ime_bridge_impl.cc

+++ b/components/arc/ime/arc_ime_bridge_impl.cc

@@ -88,8 +88,9 @@ ArcImeBridgeImpl::~ArcImeBridgeImpl() {

}

void ArcImeBridgeImpl::OnInstanceReady() {

- bridge_service_->ime()->instance()->Init(

- binding_.CreateInterfacePtrAndBind());

+ auto* instance = bridge_service_->ime()->GetInstanceForMethod("Init");

+ CHECK(instance);

+ instance->Init(binding_.CreateInterfacePtrAndBind());

}

void ArcImeBridgeImpl::SendSetCompositionText(