chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc - Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)

Patch Set: Address comments from Luis Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/arc/arc_auth_service.cc ('K') | « chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc ('k') | chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc

diff --git a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc b/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc

index f2d0dba50a4988d7bde3bcee08f5fb7a1d07c921..601e410fada7a33851c065d254708d578ef59518 100644

--- a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc

+++ b/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc

@@ -42,7 +42,7 @@ bool ArcPackageSyncDataTypeController::ReadyForStart() const {

ArcAppListPrefs* prefs = ArcAppListPrefs::Get(profile_);

return profile_->GetPrefs()->GetBoolean(

sync_driver::SyncPrefs::GetPrefNameForDataType(type())) &&

- prefs && prefs->app_instance_holder()->instance();

+ prefs && prefs->app_instance_holder()->has_instance();

}

void ArcPackageSyncDataTypeController::OnArcAppsSyncPrefChanged() {