Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/arc/crash_collector/arc_crash_collector_bridge.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: rebased to catch up tot Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc ('K') | « components/arc/clipboard/arc_clipboard_bridge.cc ('k') | components/arc/ime/arc_ime_bridge_impl.cc » ('j') | components/arc/instance_holder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/crash_collector/arc_crash_collector_bridge.cc
diff --git a/components/arc/crash_collector/arc_crash_collector_bridge.cc b/components/arc/crash_collector/arc_crash_collector_bridge.cc
index 8557308a6b87703c0994a97aa5dbbffd3c395439..4ee2f6e8f77a1baccb931ea0d60ffd251eebaf61 100644
--- a/components/arc/crash_collector/arc_crash_collector_bridge.cc
+++ b/components/arc/crash_collector/arc_crash_collector_bridge.cc
@@ -31,8 +31,10 @@ ArcCrashCollectorBridge::~ArcCrashCollectorBridge() {
void ArcCrashCollectorBridge::OnInstanceReady() {
mojom::CrashCollectorHostPtr host_ptr;
binding_.Bind(mojo::GetProxy(&host_ptr));
- arc_bridge_service()->crash_collector()->instance()->Init(
- std::move(host_ptr));
+ auto* instance =
+ arc_bridge_service()->crash_collector()->GetInstanceForMethod("Init");
+ CHECK(instance);
+ instance->Init(std::move(host_ptr));
}
void ArcCrashCollectorBridge::DumpCrash(const mojo::String& type,
« chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc ('K') | « components/arc/clipboard/arc_clipboard_bridge.cc ('k') | components/arc/ime/arc_ime_bridge_impl.cc » ('j') | components/arc/instance_holder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698