chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc - Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)

Patch Set: rebased to catch up tot Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc

diff --git a/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc b/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc

index 22c1dab7c6f740b944141582ac0bf4ed6c7f0cb1..b440e327f85a4fca1a82ee1a5bb0d38af45a31e4 100644

--- a/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc

+++ b/chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc

@@ -288,7 +288,8 @@ void ArcDownloadsWatcherService::OnDownloadsChanged(

mojo::Array<mojo::String> paths) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- auto* instance = arc_bridge_service()->file_system()->instance();

+ auto* instance = arc_bridge_service()->file_system()->GetInstanceForMethod(

+ "RequestMediaScan");

if (!instance)

return;

instance->RequestMediaScan(std::move(paths));