Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: components/arc/intent_helper/arc_intent_helper_bridge.h

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/intent_helper/arc_intent_helper_bridge.h
diff --git a/components/arc/intent_helper/arc_intent_helper_bridge.h b/components/arc/intent_helper/arc_intent_helper_bridge.h
index 445c1cb9c8f1f80b55eacbcb96b8e42b3e04b78b..22cc2daf582d71c44fe3f7083f6193cf6748ca93 100644
--- a/components/arc/intent_helper/arc_intent_helper_bridge.h
+++ b/components/arc/intent_helper/arc_intent_helper_bridge.h
@@ -79,12 +79,14 @@ class ArcIntentHelperBridge
// Gets the mojo instance if it's available. On failure, returns nullptr and
// updates |out_error_code| if it's not nullptr.
static mojom::IntentHelperInstance* GetIntentHelperInstanceWithErrorCode(
- int min_instance_version,
+ const std::string& method_name_for_logging,
+ uint32_t min_instance_version,
GetResult* out_error_code);
// Does the same as above without asking for the error code.
static mojom::IntentHelperInstance* GetIntentHelperInstance(
- int min_instance_version);
+ const std::string& method_name_for_logging,
+ uint32_t min_instance_version);
private:
mojo::Binding<mojom::IntentHelperHost> binding_;

Powered by Google App Engine
This is Rietveld 408576698