Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/arc/ime/arc_ime_bridge_impl.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/memory/tab_manager_delegate_chromeos.h ('K') | « components/arc/crash_collector/arc_crash_collector_bridge.cc ('k') | components/arc/instance_holder.h » ('j') | components/arc/instance_holder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/ime/arc_ime_bridge_impl.cc
diff --git a/components/arc/ime/arc_ime_bridge_impl.cc b/components/arc/ime/arc_ime_bridge_impl.cc
index 4f75aed8fb25791b2beab816e77ac2e6502688fc..0582c93cb7395f4778a23fb94857ed2dbfca9664 100644
--- a/components/arc/ime/arc_ime_bridge_impl.cc
+++ b/components/arc/ime/arc_ime_bridge_impl.cc
@@ -88,8 +88,10 @@ ArcImeBridgeImpl::~ArcImeBridgeImpl() {
}
void ArcImeBridgeImpl::OnInstanceReady() {
- bridge_service_->ime()->instance()->Init(
- binding_.CreateInterfacePtrAndBind());
+ auto* instance = bridge_service_->ime()->GetInstanceForMethod("Init");
+ if (!instance)
+ return;
+ instance->Init(binding_.CreateInterfacePtrAndBind());
}
void ArcImeBridgeImpl::SendSetCompositionText(
« chrome/browser/memory/tab_manager_delegate_chromeos.h ('K') | « components/arc/crash_collector/arc_crash_collector_bridge.cc ('k') | components/arc/instance_holder.h » ('j') | components/arc/instance_holder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698