Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: chrome/browser/chromeos/arc/arc_print_service.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_print_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_print_service.cc b/chrome/browser/chromeos/arc/arc_print_service.cc
index 28de889953839e35bfa71d53f4c6f3f8dde43fe8..efd7a850b7d13d1e4f6edd4031dc2ceac1291c58 100644
--- a/chrome/browser/chromeos/arc/arc_print_service.cc
+++ b/chrome/browser/chromeos/arc/arc_print_service.cc
@@ -67,12 +67,9 @@ ArcPrintService::~ArcPrintService() {
void ArcPrintService::OnInstanceReady() {
mojom::PrintInstance* print_instance =
- arc_bridge_service()->print()->instance();
- if (!print_instance) {
- LOG(ERROR) << "OnPrintInstanceReady called, but no print instance found";
+ arc_bridge_service()->print()->GetInstanceForMethod("Init");
+ if (!print_instance)
return;
- }
-
print_instance->Init(binding_.CreateInterfacePtrAndBind());
}

Powered by Google App Engine
This is Rietveld 408576698