Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/arc/audio/arc_audio_bridge.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: rebase, no code change Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/audio/arc_audio_bridge.cc
diff --git a/components/arc/audio/arc_audio_bridge.cc b/components/arc/audio/arc_audio_bridge.cc
index 222b5bc4fcba2c30849820815550fa600bded69f..02f4cecead24d5e90b7f9beb0ed1b7a8366de292 100644
--- a/components/arc/audio/arc_audio_bridge.cc
+++ b/components/arc/audio/arc_audio_bridge.cc
@@ -11,6 +11,14 @@
namespace arc {
+namespace {
+
+// Note: unlike most of our mojom definitions, AudioInstance::Init's minimum
+// version is not zero.
+constexpr uint32_t kMinInstanceVersionForInit = 1;
+
+} // namespace
+
ArcAudioBridge::ArcAudioBridge(ArcBridgeService* bridge_service)
: ArcService(bridge_service), binding_(this) {
arc_bridge_service()->audio()->AddObserver(this);
@@ -29,16 +37,9 @@ ArcAudioBridge::~ArcAudioBridge() {
void ArcAudioBridge::OnInstanceReady() {
mojom::AudioInstance* audio_instance =
- arc_bridge_service()->audio()->instance();
- if (!audio_instance) {
- LOG(ERROR) << "OnAudioInstanceReady called, "
- << "but no audio instance found";
- return;
- }
- if (arc_bridge_service()->audio()->version() < 1) {
- LOG(WARNING) << "Audio instance is too old and does not support Init()";
- return;
- }
+ arc_bridge_service()->audio()->GetInstanceForMethod(
+ "Init", kMinInstanceVersionForInit);
+ DCHECK(audio_instance); // the instance on ARC side is too old.
audio_instance->Init(binding_.CreateInterfacePtrAndBind());
}
@@ -82,7 +83,7 @@ void ArcAudioBridge::SendSwitchState(bool headphone_inserted,
VLOG(1) << "Send switch state " << switch_state;
mojom::AudioInstance* audio_instance =
- arc_bridge_service()->audio()->instance();
+ arc_bridge_service()->audio()->GetInstanceForMethod("NotifySwitchState");
if (audio_instance)
audio_instance->NotifySwitchState(switch_state);
}
« no previous file with comments | « chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc ('k') | components/arc/bluetooth/arc_bluetooth_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698