Always use arc::InstanceHolder<T>::GetInstanceForMethod

components/arc/metrics/arc_metrics_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/metrics/arc_metrics_service.h"
 
 #include <string>
 #include <utility>
 
 #include "base/logging.h"
@@ skipping 58 matching lines @@
                this, &ArcMetricsService::RequestProcessList);
 }
 
 void ArcMetricsService::OnProcessInstanceClosed() {
   VLOG(2) << "Stop updating process list.";
   timer_.Stop();
 }
 
 void ArcMetricsService::RequestProcessList() {
   mojom::ProcessInstance* process_instance =
-      arc_bridge_service()->process()->instance();
-  if (!process_instance) {
-    LOG(ERROR) << "No process instance found before RequestProcessList";
+      arc_bridge_service()->process()->GetInstanceForMethod(
+          "RequestProcessList");
+  if (!process_instance)
     return;
-  }
-
   VLOG(2) << "RequestProcessList";
   process_instance->RequestProcessList(base::Bind(
       &ArcMetricsService::ParseProcessList, weak_ptr_factory_.GetWeakPtr()));
 }
 
 void ArcMetricsService::ParseProcessList(
     mojo::Array<arc::mojom::RunningAppProcessInfoPtr> processes) {
   int running_app_count = 0;
   for (const auto& process : processes) {
     const mojo::String& process_name = process->process_name;
@@ skipping 19 matching lines @@
 }
 
 void ArcMetricsService::OnArcStartTimeRetrieved(
     bool success,
     base::TimeTicks arc_start_time) {
   DCHECK(CalledOnValidThread());
   if (!success) {
     LOG(ERROR) << "Failed to retrieve ARC start timeticks.";
     return;
   }
-  if (!arc_bridge_service()->metrics()->instance()) {
-    LOG(ERROR) << "ARC metrics instance went away while retrieving start time.";
+  auto* instance =
+      arc_bridge_service()->metrics()->GetInstanceForMethod("Init");
+  if (!instance)
     return;
-  }
 
   // The binding of host interface is deferred until the ARC start time is
   // retrieved here because it prevents race condition of the ARC start
   // time availability in ReportBootProgress().
   if (!binding_.is_bound()) {
     mojom::MetricsHostPtr host_ptr;
     binding_.Bind(mojo::GetProxy(&host_ptr));
-    arc_bridge_service()->metrics()->instance()->Init(std::move(host_ptr));
+    instance->Init(std::move(host_ptr));
   }
   arc_start_time_ = arc_start_time;
   VLOG(2) << "ARC start @" << arc_start_time_;
 }
 
 void ArcMetricsService::ReportBootProgress(
     mojo::Array<arc::mojom::BootProgressEventPtr> events) {
   DCHECK(CalledOnValidThread());
   int64_t arc_start_time_in_ms =
       (arc_start_time_ - base::TimeTicks()).InMilliseconds();
@@ skipping 24 matching lines @@
 
 void ArcMetricsService::ProcessObserver::OnInstanceReady() {
   arc_metrics_service_->OnProcessInstanceReady();
 }
 
 void ArcMetricsService::ProcessObserver::OnInstanceClosed() {
   arc_metrics_service_->OnProcessInstanceClosed();
 }
 
 }  // namespace arc