Always use arc::InstanceHolder<T>::GetInstanceForMethod

chrome/browser/memory/tab_manager_delegate_chromeos.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEMORY_TAB_MANAGER_DELEGATE_CHROMEOS_H_
 #define CHROME_BROWSER_MEMORY_TAB_MANAGER_DELEGATE_CHROMEOS_H_
 
 #include <memory>
 #include <utility>
 #include <vector>
@@ skipping 29 matching lines @@
   FOCUSED_TAB = FOCUSED_APP,
 
   VISIBLE_APP = 2,
   BACKGROUND_TAB = 3,
   BACKGROUND_APP = 4,
   UNKNOWN_TYPE = 5,
 };
 
 // The Chrome OS TabManagerDelegate is responsible for keeping the
 // renderers' scores up to date in /proc/<pid>/oom_score_adj.
-class TabManagerDelegate
-    : public arc::InstanceHolder<arc::mojom::ProcessInstance>::Observer,
-      public aura::client::ActivationChangeObserver,
-      public content::NotificationObserver,
-      public chrome::BrowserListObserver {
+class TabManagerDelegate : public aura::client::ActivationChangeObserver,
+                           public content::NotificationObserver,
+                           public chrome::BrowserListObserver {
  public:
   class MemoryStat;
 
   explicit TabManagerDelegate(const base::WeakPtr<TabManager>& tab_manager);
 
   TabManagerDelegate(const base::WeakPtr<TabManager>& tab_manager,
                      TabManagerDelegate::MemoryStat* mem_stat);
 
   ~TabManagerDelegate() override;
 
   void OnBrowserSetLastActive(Browser* browser) override;
 
-  // InstanceHolder<arc::mojom::ProcessInstance>::Observer overrides.
-  void OnInstanceReady() override;
-  void OnInstanceClosed() override;
-
   // aura::ActivationChangeObserver overrides.
   void OnWindowActivated(
       aura::client::ActivationChangeObserver::ActivationReason reason,
       aura::Window* gained_active,
       aura::Window* lost_active) override;
 
   // Kills a process on memory pressure.
   void LowMemoryKill(const TabStatsList& tab_stats);
 
   // Returns oom_score_adj of a process if the score is cached by |this|.
@@ skipping 88 matching lines @@
   // Holds the info of the newly focused tab or app. Its OOM score would be
   // adjusted when |focus_process_score_adjust_timer_| is expired.
   std::unique_ptr<FocusedProcess> focused_process_;
 
   // Map maintaining the process handle - oom_score mapping.
   ProcessScoreMap oom_score_map_;
 
   // Util for getting system memory status.
   std::unique_ptr<TabManagerDelegate::MemoryStat> mem_stat_;
 
-  // Holds a weak pointer to arc::mojom::ProcessInstance.
-  arc::mojom::ProcessInstance* arc_process_instance_;

[Luis Héctor Chávez, 2016/09/23 22:51:03]

oh! good catch!

[Yusuke Sato, 2016/09/24 00:15:22]

Acknowledged.

-  // Current ProcessInstance version.
-  int arc_process_instance_version_;
-
   // Reports UMA histograms.
   std::unique_ptr<UmaReporter> uma_;
 
   // Weak pointer factory used for posting tasks to other threads.
   base::WeakPtrFactory<TabManagerDelegate> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(TabManagerDelegate);
 };
 
 // On ARC enabled machines, either a tab or an app could be a possible
@@ skipping 51 matching lines @@
   // reported if available memory is under the number.
   static int LowMemoryMarginKB();
 
   // Reads in an integer.
   static int ReadIntFromFile(const char* file_name, int default_val);
 };
 
 }  // namespace memory
 
 #endif  // CHROME_BROWSER_MEMORY_TAB_MANAGER_DELEGATE_CHROMEOS_H_