Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Side by Side Diff: components/arc/intent_helper/arc_intent_helper_bridge.h

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: rebase, no code change Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_ 5 #ifndef COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
6 #define COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_ 6 #define COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 static bool IsIntentHelperPackage(const std::string& package_name); 72 static bool IsIntentHelperPackage(const std::string& package_name);
73 73
74 // Filters out handlers that belong to the intent_helper apk and returns 74 // Filters out handlers that belong to the intent_helper apk and returns
75 // a new array. 75 // a new array.
76 static mojo::Array<mojom::IntentHandlerInfoPtr> FilterOutIntentHelper( 76 static mojo::Array<mojom::IntentHandlerInfoPtr> FilterOutIntentHelper(
77 mojo::Array<mojom::IntentHandlerInfoPtr> handlers); 77 mojo::Array<mojom::IntentHandlerInfoPtr> handlers);
78 78
79 // Gets the mojo instance if it's available. On failure, returns nullptr and 79 // Gets the mojo instance if it's available. On failure, returns nullptr and
80 // updates |out_error_code| if it's not nullptr. 80 // updates |out_error_code| if it's not nullptr.
81 static mojom::IntentHelperInstance* GetIntentHelperInstanceWithErrorCode( 81 static mojom::IntentHelperInstance* GetIntentHelperInstanceWithErrorCode(
82 int min_instance_version, 82 const std::string& method_name_for_logging,
83 uint32_t min_instance_version,
83 GetResult* out_error_code); 84 GetResult* out_error_code);
84 85
85 // Does the same as above without asking for the error code. 86 // Does the same as above without asking for the error code.
86 static mojom::IntentHelperInstance* GetIntentHelperInstance( 87 static mojom::IntentHelperInstance* GetIntentHelperInstance(
87 int min_instance_version); 88 const std::string& method_name_for_logging,
89 uint32_t min_instance_version);
88 90
89 private: 91 private:
90 mojo::Binding<mojom::IntentHelperHost> binding_; 92 mojo::Binding<mojom::IntentHelperHost> binding_;
91 scoped_refptr<ActivityIconLoader> icon_loader_; 93 scoped_refptr<ActivityIconLoader> icon_loader_;
92 scoped_refptr<LocalActivityResolver> activity_resolver_; 94 scoped_refptr<LocalActivityResolver> activity_resolver_;
93 95
94 base::ThreadChecker thread_checker_; 96 base::ThreadChecker thread_checker_;
95 97
96 DISALLOW_COPY_AND_ASSIGN(ArcIntentHelperBridge); 98 DISALLOW_COPY_AND_ASSIGN(ArcIntentHelperBridge);
97 }; 99 };
98 100
99 } // namespace arc 101 } // namespace arc
100 102
101 #endif // COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_ 103 #endif // COMPONENTS_ARC_INTENT_HELPER_ARC_INTENT_HELPER_BRIDGE_H_
OLDNEW
« no previous file with comments | « components/arc/intent_helper/activity_icon_loader.cc ('k') | components/arc/intent_helper/arc_intent_helper_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698