Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: chrome/browser/chromeos/arc/gpu_arc_video_service_host.cc

Issue 2357053002: Always use arc::InstanceHolder<T>::GetInstanceForMethod (Closed)
Patch Set: rebase, no code change Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/gpu_arc_video_service_host.h" 5 #include "chrome/browser/chromeos/arc/gpu_arc_video_service_host.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility>
8 9
9 #include "base/location.h" 10 #include "base/location.h"
10 #include "base/logging.h" 11 #include "base/logging.h"
11 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
12 #include "base/threading/thread_task_runner_handle.h" 13 #include "base/threading/thread_task_runner_handle.h"
13 #include "components/arc/common/video_accelerator.mojom.h" 14 #include "components/arc/common/video_accelerator.mojom.h"
14 #include "content/public/browser/browser_thread.h" 15 #include "content/public/browser/browser_thread.h"
15 #include "content/public/browser/gpu_service_registry.h" 16 #include "content/public/browser/gpu_service_registry.h"
16 #include "mojo/edk/embedder/embedder.h" 17 #include "mojo/edk/embedder/embedder.h"
17 #include "mojo/edk/embedder/platform_channel_pair.h" 18 #include "mojo/edk/embedder/platform_channel_pair.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 arc_bridge_service()->video()->AddObserver(this); 63 arc_bridge_service()->video()->AddObserver(this);
63 } 64 }
64 65
65 GpuArcVideoServiceHost::~GpuArcVideoServiceHost() { 66 GpuArcVideoServiceHost::~GpuArcVideoServiceHost() {
66 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 67 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
67 arc_bridge_service()->video()->RemoveObserver(this); 68 arc_bridge_service()->video()->RemoveObserver(this);
68 } 69 }
69 70
70 void GpuArcVideoServiceHost::OnInstanceReady() { 71 void GpuArcVideoServiceHost::OnInstanceReady() {
71 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 72 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
72 auto* video_instance = arc_bridge_service()->video()->instance(); 73 auto* video_instance =
74 arc_bridge_service()->video()->GetInstanceForMethod("Init");
73 DCHECK(video_instance); 75 DCHECK(video_instance);
74 video_instance->Init(binding_.CreateInterfacePtrAndBind()); 76 video_instance->Init(binding_.CreateInterfacePtrAndBind());
75 } 77 }
76 78
77 void GpuArcVideoServiceHost::DeprecatedOnRequestArcVideoAcceleratorChannel( 79 void GpuArcVideoServiceHost::DeprecatedOnRequestArcVideoAcceleratorChannel(
78 const DeprecatedOnRequestArcVideoAcceleratorChannelCallback& callback) { 80 const DeprecatedOnRequestArcVideoAcceleratorChannelCallback& callback) {
79 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 81 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
80 82
81 // Hardcode pid 0 since it is unused in mojo. 83 // Hardcode pid 0 since it is unused in mojo.
82 const base::ProcessHandle kUnusedChildProcessHandle = 84 const base::ProcessHandle kUnusedChildProcessHandle =
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 return; 147 return;
146 } 148 }
147 callback.Run(std::move(child_handle), token); 149 callback.Run(std::move(child_handle), token);
148 150
149 mojo::MakeStrongBinding(base::MakeUnique<VideoAcceleratorFactoryService>(), 151 mojo::MakeStrongBinding(base::MakeUnique<VideoAcceleratorFactoryService>(),
150 mojo::MakeRequest<mojom::VideoAcceleratorFactory>( 152 mojo::MakeRequest<mojom::VideoAcceleratorFactory>(
151 std::move(server_pipe))); 153 std::move(server_pipe)));
152 } 154 }
153 155
154 } // namespace arc 156 } // namespace arc
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/arc/arc_wallpaper_service.cc ('k') | chrome/browser/chromeos/file_manager/arc_file_tasks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698