Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2357043003: Remove WebCallbackTask (Closed)

Created:
4 years, 3 months ago by tzik
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, scheduler-bugs_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebCallbackTask Since WebTaskRunner can handle base::Closure, WebCallbackTask is no longer needed. Committed: https://crrev.com/5f3ffb296e91d9616af89883b9d64bfa1be60b34 Cr-Commit-Position: refs/heads/master@{#420083}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : remove WebTaskRunner::postTask(base::Closure). git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -126 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/test_runner/event_sender.cc View 1 2 2 chunks +9 lines, -10 lines 0 comments Download
M components/test_runner/mock_color_chooser.cc View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M components/test_runner/mock_web_midi_accessor.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/mock_web_speech_recognizer.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M components/test_runner/mock_webrtc_data_channel_handler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/test_runner/mock_webrtc_dtmf_sender_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/mock_webrtc_peer_connection_handler.cc View 5 chunks +14 lines, -15 lines 0 comments Download
M components/test_runner/spell_check_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/test_runner.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/test_runner/test_runner_for_specific_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
D components/test_runner/web_task.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/test_runner/web_task.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M components/test_runner/web_test_delegate.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M components/test_runner/web_view_test_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/web_widget_test_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
tzik
PTAL
4 years, 3 months ago (2016-09-21 10:13:09 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-21 10:18:57 UTC) #9
alex clarke (OOO till 29th)
https://codereview.chromium.org/2357043003/diff/20001/third_party/WebKit/public/platform/WebTaskRunner.h File third_party/WebKit/public/platform/WebTaskRunner.h (right): https://codereview.chromium.org/2357043003/diff/20001/third_party/WebKit/public/platform/WebTaskRunner.h#newcode45 third_party/WebKit/public/platform/WebTaskRunner.h:45: virtual void postTask(const WebTraceLocation&, const base::Closure&) = 0; Getting ...
4 years, 3 months ago (2016-09-21 10:38:40 UTC) #10
tzik
https://codereview.chromium.org/2357043003/diff/20001/third_party/WebKit/public/platform/WebTaskRunner.h File third_party/WebKit/public/platform/WebTaskRunner.h (right): https://codereview.chromium.org/2357043003/diff/20001/third_party/WebKit/public/platform/WebTaskRunner.h#newcode45 third_party/WebKit/public/platform/WebTaskRunner.h:45: virtual void postTask(const WebTraceLocation&, const base::Closure&) = 0; On ...
4 years, 3 months ago (2016-09-21 14:32:09 UTC) #15
alex clarke (OOO till 29th)
lgtm
4 years, 3 months ago (2016-09-21 15:42:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357043003/40001
4 years, 3 months ago (2016-09-21 16:48:42 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 16:55:12 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 16:56:38 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5f3ffb296e91d9616af89883b9d64bfa1be60b34
Cr-Commit-Position: refs/heads/master@{#420083}

Powered by Google App Engine
This is Rietveld 408576698