Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5408)

Unified Diff: chrome/browser/android/offline_pages/prerender_adapter.cc

Issue 2357013002: Fix an issue that PrerenderLoader::OnPrerenderStart() never gets called. (Closed)
Patch Set: remove OnPrerenderStarted Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerender_adapter.cc
diff --git a/chrome/browser/android/offline_pages/prerender_adapter.cc b/chrome/browser/android/offline_pages/prerender_adapter.cc
index 7764e1642af36dec9e6ea33e55aa2f1fead90962..5929cb5fc2d112758461495fae0f891795c3b358 100644
--- a/chrome/browser/android/offline_pages/prerender_adapter.cc
+++ b/chrome/browser/android/offline_pages/prerender_adapter.cc
@@ -42,12 +42,18 @@ bool PrerenderAdapter::StartPrerender(
DCHECK(manager);
// Start prerendering the url and capture the handle for the prerendering.
+ // Note: PrerenderHandle::OnPrerenderStart() will get called inside
dougarnett 2016/09/21 17:01:27 maybe drop this comment with something similar by
qinmin 2016/09/21 17:18:01 Done.
+ // PrerenderManager::AddPrerenderForOffline(), this is before the observer is
+ // set.
active_handle_ =
manager->AddPrerenderForOffline(url, session_storage_namespace, size);
if (!active_handle_)
return false;
+ DCHECK(active_handle_->contents());
+ DCHECK(active_handle_->contents()->prerendering_has_started());
active_handle_->SetObserver(this);
+
return true;
}
@@ -80,8 +86,7 @@ void PrerenderAdapter::DestroyActive() {
}
void PrerenderAdapter::OnPrerenderStart(prerender::PrerenderHandle* handle) {
- DCHECK_EQ(active_handle_.get(), handle);
- observer_->OnPrerenderStart();
+ NOTREACHED();
dougarnett 2016/09/21 17:01:27 maybe some comment here instead, eg, // Not expec
qinmin 2016/09/21 17:18:01 Done.
}
void PrerenderAdapter::OnPrerenderStopLoading(
« no previous file with comments | « chrome/browser/android/offline_pages/prerender_adapter.h ('k') | chrome/browser/android/offline_pages/prerendering_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698