Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.cc

Issue 2357013002: Fix an issue that PrerenderLoader::OnPrerenderStart() never gets called. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/prerender_adapter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index bbc1fe0851ac8f1d9753ce70fbdbde02b3ff795a..5882974fb8236f72deb3a1ed1b401dd895a65459 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -59,6 +59,10 @@ bool PrerenderingLoader::LoadPage(const GURL& url,
callback_ = callback;
session_contents_.swap(new_web_contents);
state_ = State::PENDING;
dougarnett 2016/09/21 16:16:51 Could just set LOADING here instead and drop the O
dougarnett 2016/09/21 16:32:40 BTW, I could do that clean up as it is a bit more
qinmin 2016/09/21 16:40:04 Can you take another look at the new patch, I have
+ // Note: Observer is attached too late when calling
+ // PrerenderAdapter::StartPrerenderer(). Call the missing OnPrerenderStart()
+ // here.
+ OnPrerenderStart();
return true;
}
« no previous file with comments | « chrome/browser/android/offline_pages/prerender_adapter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698