Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2357003002: [modules] Also (de-)serialize imports. (Closed)

Created:
4 years, 3 months ago by neis
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Also (de-)serialize imports. This is in preparation for basic support of import statements. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/a037f350eeb521041f4e68d4714573d67a12d57e Cr-Commit-Position: refs/heads/master@{#39568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2 lines) Patch
M src/ast/scopeinfo.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 3 months ago (2016-09-20 22:26:47 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-20 22:27:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2357003002/1
4 years, 3 months ago (2016-09-20 22:28:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:58:00 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:58:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a037f350eeb521041f4e68d4714573d67a12d57e
Cr-Commit-Position: refs/heads/master@{#39568}

Powered by Google App Engine
This is Rietveld 408576698