Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2356993002: Revert of Add request-level caching for privileged queries. (Closed)

Created:
4 years, 3 months ago by sullivan
Modified:
4 years, 3 months ago
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Add request-level caching for privileged queries. (patchset #5 id:80001 of https://codereview.chromium.org/2350113002/ ) Reason for revert: This causes some errors for signed-out users when viewing charts. Reverting while I investigate. Original issue's description: > Add request-level caching for privileged queries. > > BUG=catapult:#2807 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4f3a13e5fdea583299ecf64e530a4b42201a7fcb TBR=benjhayden@chromium.org,aiolos@chromium.org,dtu@chromium.org,eakuefner@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2807 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9f0befafcd158d2b5d2291870ac38a702d5833d4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -65 lines) Patch
M dashboard/dashboard/datastore_hooks.py View 3 chunks +13 lines, -33 lines 0 comments Download
M dashboard/dashboard/datastore_hooks_test.py View 3 chunks +0 lines, -15 lines 0 comments Download
M dashboard/dashboard/layered_cache_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M dashboard/dashboard/list_tests_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M dashboard/dashboard/models/internal_only_model_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M dashboard/dashboard/namespaced_stored_object_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M dashboard/dashboard/start_try_job_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M dashboard/dashboard/testing_common.py View 2 chunks +0 lines, -8 lines 0 comments Download
M dashboard/dashboard/update_test_suites_test.py View 2 chunks +0 lines, -3 lines 0 comments Download
M dashboard/dashboard/utils_test.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sullivan
Created Revert of Add request-level caching for privileged queries.
4 years, 3 months ago (2016-09-20 22:23:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356993002/1
4 years, 3 months ago (2016-09-20 22:23:28 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:23:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698