Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2356953003: Add page_transition_util_unittest.cc (Closed)

Created:
4 years, 3 months ago by Yusuke Sato
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add page_transition_util_unittest.cc BUG=None TEST=try Committed: https://crrev.com/1e98dc42d3ef1dfb35de77b10ecdbad1e0347130 Cr-Commit-Position: refs/heads/master@{#419975}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/arc/page_transition_util_unittest.cc View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Yusuke Sato
owners, please take a look. Let me add the test as a utility class without ...
4 years, 3 months ago (2016-09-21 01:01:36 UTC) #6
xiyuan
lgtm
4 years, 3 months ago (2016-09-21 04:31:30 UTC) #9
Luis Héctor Chávez
more tests? of course lgtm!
4 years, 3 months ago (2016-09-21 04:40:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356953003/20001
4 years, 3 months ago (2016-09-21 04:44:35 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 04:50:03 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 04:51:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e98dc42d3ef1dfb35de77b10ecdbad1e0347130
Cr-Commit-Position: refs/heads/master@{#419975}

Powered by Google App Engine
This is Rietveld 408576698