Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Side by Side Diff: clang_format_merge_driver.py

Issue 2356933002: Introduce git merge driver for the blink reformatting (Closed)
Patch Set: Remove gclient.py hook and extra \n Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « clang_format_merge_driver.bat ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 #!/usr/bin/env python
2 # Copyright 2016 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file.
5 """clang-format 3-way merge driver.
6
7 This is a custom merge driver for git that helps automatically resolves
8 conflicts caused by clang-format changes. The conflict resolution
9 strategy is extremely simple: it simply clang-formats the current,
10 ancestor branch's, and other branch's version of the file and delegates
11 the remaining work to git merge-file.
12
13 See https://git-scm.com/docs/gitattributes ("Defining a custom merge
14 driver") for more details.
15 """
16
17 import subprocess
18 import sys
19
20 import clang_format
21
22
23 def main():
24 if len(sys.argv) < 5:
25 print('usage: %s <base> <current> <others> <path in the tree>' %
26 sys.argv[0])
27 sys.exit(1)
28
29 base, current, others, file_name_in_tree = sys.argv[1:5]
30 print 'Running clang-format 3-way merge driver on ' + file_name_in_tree
31
32 try:
33 tool = clang_format.FindClangFormatToolInChromiumTree()
34 for fpath in base, current, others:
35 # Typically, clang-format is used with the -i option to rewrite files
36 # in-place. However, merge files live in the repo root, so --style=file
37 # will always pick up the root .clang-format.
38 #
39 # Instead, this tool uses --assume-filename so clang-format will pick up
40 # the appropriate .clang-format. Unfortunately, --assume-filename only
41 # works when the input is from stdin, so the file I/O portions are lifted
42 # up into the script as well.
43 with open(fpath, 'rb') as input_file:
44 output = subprocess.check_output(
45 [tool, '--assume-filename=%s' % file_name_in_tree, '--style=file'],
46 stdin=input_file)
47 with open(fpath, 'wb') as output_file:
48 output_file.write(output)
49 except clang_format.NotFoundError, e:
50 print e
51 print 'Failed to find clang-format. Falling-back on standard 3-way merge'
52
53 return subprocess.call(['git', 'merge-file', '-Lcurrent', '-Lbase', '-Lother',
54 current, base, others])
55
56
57 if __name__ == '__main__':
58 sys.exit(main())
OLDNEW
« no previous file with comments | « clang_format_merge_driver.bat ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698