Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 235693002: Merge 260900 "linux_aura: Port GtkKeybindingsHandler to Aura." (Closed)

Created:
6 years, 8 months ago by msw
Modified:
6 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Merge 260900 "linux_aura: Port GtkKeybindingsHandler to Aura." > linux_aura: Port GtkKeybindingsHandler to Aura. > > This is a quick hack to move the current GtkKeybindingsHandler code into > aura builds. This is necessary so that Linux users who have set custom > keybindings can use them in edit fields. This only works in the content > area; further patches are needed for this to work in views. > > This redoes the interface so that instead of being hard coded into > content, we have a general interface set in ui/wm/. This should allow > views to also use this code in ui/views/, as well as its current usage > in content/. > > BUG=319437, 358297 > R=piman@chromium.org, sadrul@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/213283004 TBR=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -6 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 2 chunks +14 lines, -0 lines 0 comments Download
A + chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/libgtk2ui/gtk2_key_bindings_handler.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/native_web_keyboard_event_aura.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +38 lines, -3 lines 0 comments Download
M content/public/browser/native_web_keyboard_event.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/events.gyp View 3 chunks +14 lines, -2 lines 0 comments Download
A + ui/events/x/text_edit_command_x11.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/x/text_edit_command_x11.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/x/text_edit_key_bindings_delegate_x11.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/events/x/text_edit_key_bindings_delegate_x11.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/linux_ui/linux_ui.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/linux_ui/linux_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
msw
6 years, 8 months ago (2014-04-11 19:02:22 UTC) #1
msw
6 years, 8 months ago (2014-04-11 19:03:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263304.

Powered by Google App Engine
This is Rietveld 408576698