Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2356923002: Flush chunks on each upload read (Closed)

Created:
4 years, 3 months ago by Charles
Modified:
4 years, 3 months ago
Reviewers:
mdumitrescu, *mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flush chunks on each upload read. The way CronetJavaEngine (which uses JavaUrlRequest) is implemented in regards to chunked uploads: 1) Is inconsistent with it's native counterpart which almost immediately writes the obtained data to the wire. 2) Makes it impossible to slowly stream data (like during a voice search) in a controlled manner. No data is sent other than at JavaUrlRequest.DEFAULT_CHUNK_LENGTH (8192) intervals. BUG=b/31592204 Committed: https://crrev.com/610153f4f770238e8cb7e17c4e3ec1d6275131a1 Cr-Commit-Position: refs/heads/master@{#419869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M components/cronet/android/api/src/org/chromium/net/JavaUrlRequest.java View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Charles
PTAL
4 years, 3 months ago (2016-09-20 21:03:15 UTC) #4
mef
On 2016/09/20 21:03:15, Charles wrote: > PTAL lgtm, but please provide more elaborate description.
4 years, 3 months ago (2016-09-20 21:50:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356923002/1
4 years, 3 months ago (2016-09-20 21:52:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:11:49 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 22:14:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/610153f4f770238e8cb7e17c4e3ec1d6275131a1
Cr-Commit-Position: refs/heads/master@{#419869}

Powered by Google App Engine
This is Rietveld 408576698