Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2356903002: Remove pre-MD find bar code in Views. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
Peter Kasting, oshima
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD find bar code in Views. BUG=648281 TBR=oshima@chromium.org Committed: https://crrev.com/ceac6e97046c46b4c10ff7e6412777ba1ce9d55c Cr-Commit-Position: refs/heads/master@{#420138}

Patch Set 1 #

Total comments: 2

Patch Set 2 : no comment at this time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -347 lines) Patch
D chrome/app/theme/default_100_percent/common/find_dialog_left.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_dialog_middle.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_dialog_right.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_dlg_left_bg.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_dlg_right_bg.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_next.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_next_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_next_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_next_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_prev.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_prev_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_prev_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_100_percent/common/find_prev_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_dialog_left.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_dialog_middle.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_dialog_right.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_dlg_left_bg.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_dlg_right_bg.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_next.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_next_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_next_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_next_pressed.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_prev.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_prev_disabled.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_prev_hover.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/find_prev_pressed.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +11 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 5 chunks +9 lines, -32 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 13 chunks +64 lines, -293 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Evan Stade
4 years, 3 months ago (2016-09-20 20:29:26 UTC) #4
Peter Kasting
LGTM https://codereview.chromium.org/2356903002/diff/1/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/2356903002/diff/1/chrome/browser/ui/views/find_bar_view.cc#newcode159 chrome/browser/ui/views/find_bar_view.cc:159: // Create a focus forwarder view which sends ...
4 years, 3 months ago (2016-09-20 20:34:02 UTC) #5
Evan Stade
https://codereview.chromium.org/2356903002/diff/1/chrome/browser/ui/views/find_bar_view.cc File chrome/browser/ui/views/find_bar_view.cc (right): https://codereview.chromium.org/2356903002/diff/1/chrome/browser/ui/views/find_bar_view.cc#newcode159 chrome/browser/ui/views/find_bar_view.cc:159: // Create a focus forwarder view which sends focus ...
4 years, 3 months ago (2016-09-21 17:06:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356903002/20001
4 years, 3 months ago (2016-09-21 17:07:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/263986)
4 years, 3 months ago (2016-09-21 17:17:46 UTC) #13
Evan Stade
On 2016/09/21 17:17:46, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 3 months ago (2016-09-21 19:22:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356903002/20001
4 years, 3 months ago (2016-09-21 19:22:44 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 19:53:27 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 19:56:56 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ceac6e97046c46b4c10ff7e6412777ba1ce9d55c
Cr-Commit-Position: refs/heads/master@{#420138}

Powered by Google App Engine
This is Rietveld 408576698