Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 23569009: Ignore failures in arithmode_gpu GM test on Nexus 4 (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Ignore failures in arithmode_gpu GM test on Nexus 4 BUG=skia:1595 R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11098

Patch Set 1 #

Total comments: 1

Patch Set 2 : manually_set_ignore_failure_bool #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 2 chunks +6 lines, -3 lines 1 comment Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
https://codereview.chromium.org/23569009/diff/1/expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23569009/diff/1/expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json#newcode200 expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json:200: "bugs": [ Created patchset 1 as follows: tools/rebaseline.py --actuals-base-url ...
7 years, 3 months ago (2013-09-05 16:22:58 UTC) #1
epoger
Ready for review at patchset 2. https://codereview.chromium.org/23569009/diff/4001/expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json File expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json (right): https://codereview.chromium.org/23569009/diff/4001/expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json#newcode203 expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json:203: "ignore-failure": true Patchset ...
7 years, 3 months ago (2013-09-05 16:25:06 UTC) #2
robertphillips
lgtm
7 years, 3 months ago (2013-09-05 16:30:07 UTC) #3
epoger
7 years, 3 months ago (2013-09-05 16:30:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11098.

Powered by Google App Engine
This is Rietveld 408576698