Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: content/renderer/webcrypto_impl_openssl.cc

Issue 23569007: WebCrypto: Implement importKey() and sign() for HMAC in NSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes to review from eroman Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/webcrypto_impl_openssl.cc
diff --git a/content/renderer/webcrypto_impl_openssl.cc b/content/renderer/webcrypto_impl_openssl.cc
index 125aee5d14b1fe82a9cbccd20db1b3514b4db32d..ecc2d7be172370f137122bf2db8ddfde157d66a5 100644
--- a/content/renderer/webcrypto_impl_openssl.cc
+++ b/content/renderer/webcrypto_impl_openssl.cc
@@ -6,7 +6,7 @@
namespace content {
-bool WebCryptoImpl::digestInternal(
+bool WebCryptoImpl::DigestInternal(
const WebKit::WebCryptoAlgorithm& algorithm,
const unsigned char* data,
size_t data_size,
@@ -16,4 +16,28 @@ bool WebCryptoImpl::digestInternal(
return false;
}
+bool WebCryptoImpl::ImportKeyInternal(
+ WebKit::WebCryptoKeyFormat format,
+ const unsigned char* key_data,
+ size_t key_data_size,
+ const WebKit::WebCryptoAlgorithm& algorithm,
+ WebKit::WebCryptoKeyUsageMask usage_mask,
+ scoped_ptr<WebKit::WebCryptoKeyHandle>* handle,
+ WebKit::WebCryptoKeyType* type) {
+ // TODO(bryaneyler): Placeholder for OpenSSL implementation.
+ // Issue http://crbug.com/267888.
+ return false;
+}
+
+bool WebCryptoImpl::SignInternal(
+ const WebKit::WebCryptoAlgorithm& algorithm,
+ const WebKit::WebCryptoKeyHandle* key,
+ const unsigned char* data,
+ size_t data_size,
eroman 2013/09/09 23:00:48 ditto here if you make the change to "unsigned int
Bryan Eyler 2013/09/10 01:15:54 Done.
+ WebKit::WebArrayBuffer* buffer) {
+ // TODO(bryaneyler): Placeholder for OpenSSL implementation.
+ // Issue http://crbug.com/267888.
+ return false;
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698