WebCrypto: Implement importKey() and sign() for HMAC in NSS

content/renderer/webcrypto_impl.h

Index: content/renderer/webcrypto_impl.h
diff --git a/content/renderer/webcrypto_impl.h b/content/renderer/webcrypto_impl.h
index 6590202474427514f27739ea7fbb802460d2e6c7..568c28cc5cc0805b45e1dd27ee1e708ee8054920 100644
--- a/content/renderer/webcrypto_impl.h
+++ b/content/renderer/webcrypto_impl.h
@@ -8,6 +8,7 @@
 #include "base/compiler_specific.h"
 
 #include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
 #include "content/common/content_export.h"
 #include "third_party/WebKit/public/platform/WebCrypto.h"
 
@@ -21,12 +22,41 @@ class CONTENT_EXPORT WebCryptoImpl
       const unsigned char* data,
       size_t data_size,
       WebKit::WebCryptoResult result);
+  virtual void importKey(
+      WebKit::WebCryptoKeyFormat format,
+      const unsigned char* key_data,
+      size_t key_data_size,
+      const WebKit::WebCryptoAlgorithm& algorithm,
+      bool extractable,
+      WebKit::WebCryptoKeyUsageMask usage_mask,
+      WebKit::WebCryptoResult result);
+  virtual void sign(
+      const WebKit::WebCryptoAlgorithm& algorithm,
+      const WebKit::WebCryptoKey& key,
+      const unsigned char* data,
+      size_t data_size,
+      WebKit::WebCryptoResult result);
 
  protected:
   FRIEND_TEST_ALL_PREFIXES(WebCryptoImplTest, DigestSampleSets);
+  FRIEND_TEST_ALL_PREFIXES(WebCryptoImplTest, HMACSampleSets);
 
-  bool digestInternal(
+  bool DigestInternal(
+      const WebKit::WebCryptoAlgorithm& algorithm,
+      const unsigned char* data,
+      size_t data_size,
+      WebKit::WebArrayBuffer* buffer);
+  bool ImportKeyInternal(
+      WebKit::WebCryptoKeyFormat format,
+      const unsigned char* key_data,
+      size_t key_data_size,

[eroman, 2013/09/09 23:00:48]

I suggest making the internal method "unsigned int" in the meantime. I will
update the virtual method once blink side gets rolled in.

[Bryan Eyler, 2013/09/10 01:15:54]

Done.

+      const WebKit::WebCryptoAlgorithm& algorithm,
+      WebKit::WebCryptoKeyUsageMask usage_mask,
+      scoped_ptr<WebKit::WebCryptoKeyHandle>* handle,
+      WebKit::WebCryptoKeyType* type);
+  bool SignInternal(
       const WebKit::WebCryptoAlgorithm& algorithm,
+      const WebKit::WebCryptoKeyHandle* key,
       const unsigned char* data,
       size_t data_size,

[eroman, 2013/09/09 23:00:48]

same here

[Bryan Eyler, 2013/09/10 01:15:54]

Done.

       WebKit::WebArrayBuffer* buffer);