WebCrypto: Implement importKey() and sign() for HMAC in NSS

content/renderer/webcrypto_impl.h

Index: content/renderer/webcrypto_impl.h
diff --git a/content/renderer/webcrypto_impl.h b/content/renderer/webcrypto_impl.h
index 6590202474427514f27739ea7fbb802460d2e6c7..4ce6c5591c608c387420b8c9d88bdce9c782de6e 100644
--- a/content/renderer/webcrypto_impl.h
+++ b/content/renderer/webcrypto_impl.h
@@ -21,15 +21,44 @@ class CONTENT_EXPORT WebCryptoImpl
       const unsigned char* data,
       size_t data_size,
       WebKit::WebCryptoResult result);
+  virtual void importKey(
+      WebKit::WebCryptoKeyFormat format,
+      const unsigned char* keyData,

[eroman, 2013/09/05 01:57:51]

style: key_data (unfortunately things can get confusing here because Blink and
Chromium have different styles!)

[Bryan Eyler, 2013/09/06 01:27:51]

Done.

+      size_t keyDataSize,

[eroman, 2013/09/05 01:57:51]

ditto

[Bryan Eyler, 2013/09/06 01:27:51]

Done.

+      const WebKit::WebCryptoAlgorithm& algorithm,
+      bool extractable,
+      WebKit::WebCryptoKeyUsageMask usage_mask,
+      WebKit::WebCryptoResult result);
+  virtual void sign(
+      const WebKit::WebCryptoAlgorithm& algorithm,
+      const WebKit::WebCryptoKey& key,
+      const unsigned char* data,
+      size_t data_size,
+      WebKit::WebCryptoResult result);
 
  protected:
   FRIEND_TEST_ALL_PREFIXES(WebCryptoImplTest, DigestSampleSets);
+  FRIEND_TEST_ALL_PREFIXES(WebCryptoImplTest, HMACSampleSets);
 
   bool digestInternal(
       const WebKit::WebCryptoAlgorithm& algorithm,
       const unsigned char* data,
       size_t data_size,
       WebKit::WebArrayBuffer* buffer);
+  bool importKeyInternal(
+      WebKit::WebCryptoKeyFormat format,
+      const unsigned char* key_data,
+      size_t key_data_size,
+      const WebKit::WebCryptoAlgorithm& algorithm,
+      bool extractable,

[eroman, 2013/09/05 01:57:51]

Can remove this it is unused.

[Bryan Eyler, 2013/09/06 01:27:51]

Done.

+      WebKit::WebCryptoKeyUsageMask usage_mask,
+      WebKit::WebCryptoKeyHandle** handle);

[eroman, 2013/09/05 01:57:51]

I asked on Elly's code review for generateKeyInternal() to be a scoped_ptr<>*
instead, I recommend the same approach for this function.

I also didn't notice on our previous code review which added digestIntenal(),
but these function names should be in chromium style. i.e.:

ImportKeyInternal().

[Bryan Eyler, 2013/09/06 01:27:51]

Done.  And fixed DigestInternal.

+  bool signInternal(
+      const WebKit::WebCryptoAlgorithm& algorithm,
+      const WebKit::WebCryptoKeyHandle* key,
+      const unsigned char* data,
+      size_t data_size,
+      WebKit::WebArrayBuffer* buffer);
 };
 
 }  // namespace content