Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2356843002: Fix 'new KnownClass.unresolvedConstructor()' type computation. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix 'new KnownClass.unresolvedConstructor()' type computation. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ff22a0fe898185085c9b23265f3c8dc43e25f6d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 4 chunks +28 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-20 17:45:04 UTC) #1
Paul Berry
lgtm
4 years, 3 months ago (2016-09-20 17:55:47 UTC) #2
scheglov
4 years, 3 months ago (2016-09-20 21:00:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ff22a0fe898185085c9b23265f3c8dc43e25f6d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698