[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb image to srgb image

[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb image to single-sampled srgb image.

Per our discussion with @piman and @kbr at https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab
Cr-Commit-Position: refs/heads/master@{#420001}

[yunchao, 2016-09-20 15:00:25]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image

BUG=634525
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/. 
The current code is correct. Juse simply remove this TODO.

BUG=634525
==========

[yunchao, 2016-09-20 15:00:25]

yunchao.he@intel.com changed reviewers:
+ cwallez@chromium.org, kbr@chromium.org, piman@chromium.org,
qiankun.miao@intel.com, zmo@chromium.org

[yunchao, 2016-09-20 15:01:49]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/. 
The current code is correct. Juse simply remove this TODO.

BUG=634525
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct. Simply remove this TODO is OK.

BUG=634525
==========

[yunchao, 2016-09-20 15:13:56]

When blitframebuffer from a multisampled srgb image, the dst resource should be
a srgb too. In addition, we have no any option to get the single-sample from the
multisampled read buffer to process the samples. It means that we have no choice
but call blitFramebuffer directly before do any processing. 

Fortunately, the conformance test about bliting multi-sampled srgb image to
single-sampled srgb image can pass both on MacOSX (OGL 4.1) and Linux OGL (4.4):
https://github.com/KhronosGroup/WebGL/pull/2034.

I also looked into the code in command buffer, the restrictions(same
format/type, and same region between read buffer and draw buffer) of bliting
from a multisampled srgb have been done in command buffer. So, there is no extra
work to do for this TODO. 

So, This small change simply remove it.

@piman and @kbr (and other reviewers), PTAL. Thanks.

[yunchao, 2016-09-20 15:19:29]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct. Simply remove this TODO is OK.

BUG=634525
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct. Simply remove this TODO is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-09-20 15:19:58]

Patchset #2 (id:20001) has been deleted

[yunchao, 2016-09-20 15:35:15]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 15:35:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yunchao, 2016-09-20 15:36:07]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sample srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct. Simply remove this TODO is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct. Simply remove this TODO is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[yunchao, 2016-09-20 15:37:22]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct. Simply remove this TODO is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO
is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-20 19:29:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:29:36]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[piman, 2016-09-20 20:55:25]

https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (left):

https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:7713: // renderbuffer.
As discussed in that other CL, there is just one more check to add, which is
that the destination must not be multisampled.

[yunchao, 2016-09-21 02:53:37]

On 2016/09/20 20:55:25, piman OOO back 2016-09-12 wrote:
>
https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (left):
> 
>
https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:7713: // renderbuffer.
> As discussed in that other CL, there is just one more check to add, which is
> that the destination must not be multisampled.

@piman, thanks for your review. 
Sorry, I forget to mention this restriction. But It is invalid if dst resources
have multisampled image, no matter the src resource is multisampled or not (or
the src is  srgb image or linear image, it doesn't matter). And Chromium have
done this validation:
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_dec....

[yunchao, 2016-09-21 03:36:01]

On 2016/09/21 02:53:37, yunchao wrote:
> On 2016/09/20 20:55:25, piman OOO back 2016-09-12 wrote:
> >
>
https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
> > File gpu/command_buffer/service/gles2_cmd_decoder.cc (left):
> > 
> >
>
https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
> > gpu/command_buffer/service/gles2_cmd_decoder.cc:7713: // renderbuffer.
> > As discussed in that other CL, there is just one more check to add, which is
> > that the destination must not be multisampled.
> 
> @piman, thanks for your review. 
> Sorry, I forget to mention this restriction. But It is invalid if dst
resources
> have multisampled image, no matter the src resource is multisampled or not (or
> the src is  srgb image or linear image, it doesn't matter). And Chromium have
> done this validation:
>
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_dec....

I have add a conformance test to cover all these restrictions at
https://github.com/KhronosGroup/WebGL/pull/2049. This test can pass on both
MacOSX(OGL 4.1) and Linux Desktop(OGL 4.5). I think the current code is OK.

[piman, 2016-09-21 05:28:05]

On 2016/09/21 03:36:01, yunchao wrote:
> On 2016/09/21 02:53:37, yunchao wrote:
> > On 2016/09/20 20:55:25, piman OOO back 2016-09-12 wrote:
> > >
> >
>
https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
> > > File gpu/command_buffer/service/gles2_cmd_decoder.cc (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2356813002/diff/40001/gpu/command_buffer/serv...
> > > gpu/command_buffer/service/gles2_cmd_decoder.cc:7713: // renderbuffer.
> > > As discussed in that other CL, there is just one more check to add, which
is
> > > that the destination must not be multisampled.
> > 
> > @piman, thanks for your review. 
> > Sorry, I forget to mention this restriction. But It is invalid if dst
> resources
> > have multisampled image, no matter the src resource is multisampled or not
(or
> > the src is  srgb image or linear image, it doesn't matter). And Chromium
have
> > done this validation:
> >
>
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_dec....
> 
> I have add a conformance test to cover all these restrictions at
> https://github.com/KhronosGroup/WebGL/pull/2049. This test can pass on both
> MacOSX(OGL 4.1) and Linux Desktop(OGL 4.5). I think the current code is OK.

Ah, ok, yes, thanks!
LGTM.

[yunchao, 2016-09-21 05:51:08]

The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 05:51:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 06:40:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 06:40:45]

Dry run: This issue passed the CQ dry run.

[yunchao, 2016-09-21 07:37:32]

The CQ bit was checked by yunchao.he@intel.com

[commit-bot: I haz the power, 2016-09-21 07:37:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 07:42:59]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO
is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO
is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-21 07:43:00]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-21 07:44:57]

Description was changed from

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO
is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
[Command buffer]: we can call blitFramebuffer directly from multi-sampled srgb
image to single-sampled srgb image.

Per our discussion with @piman and @kbr at
https://codereview.chromium.org/2286593002/,
The current code is correct, no further work to be done. Simply remove this TODO
is OK.

BUG=634525
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab
Cr-Commit-Position: refs/heads/master@{#420001}
==========

[commit-bot: I haz the power, 2016-09-21 07:44:58]

Patchset 2 (id:??) landed as
https://crrev.com/6fd16244a59d8cb93a7361b9e35e2c3fb7bfb8ab
Cr-Commit-Position: refs/heads/master@{#420001}