IdleWakeups tool

IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

This was used for browsers efficiency comparison - chrome vs. Edge and
Firefox.

Also the tool was used as a basis for prototyping and implementing new
OS_WIN features in Chrome Task Manager including:
- Idle Wakeups column.
- More power/memory efficient implementation of Memory column.

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.

Committed: https://crrev.com/a194af037226cf51bca27ccfc9941932e739ba60
Cr-Commit-Position: refs/heads/master@{#420811}

[stanisc, 2016-09-21 17:47:33]

stanisc@chromium.org changed reviewers:
+ brucedawson@chromium.org, kulshin@chromium.org

[stanisc, 2016-09-21 17:47:34]

PTAL

[Ilya Kulshin, 2016-09-21 23:14:24]

lgtm

[brucedawson, 2016-09-21 23:23:46]

Two suggestions for the description:

< for all running Chrome
> for all specified browser

Or something else that indicates it isn't specific to Chrome

< System wide power usage (as reported by Intel Power driver)
> System wide CPU power usage (as reported by Intel Power driver)

[brucedawson, 2016-09-21 23:30:49]

Does this have the fixes and improvements from when the code got added to the
task manager?

https://codereview.chromium.org/2356753004/diff/20001/tools/win/IdleWakeups/s...
File tools/win/IdleWakeups/stdafx.cpp (right):

https://codereview.chromium.org/2356753004/diff/20001/tools/win/IdleWakeups/s...
tools/win/IdleWakeups/stdafx.cpp:8: // and not in this file
Delete TODO

[stanisc, 2016-09-21 23:38:55]

On 2016/09/21 23:30:49, brucedawson wrote:
> Does this have the fixes and improvements from when the code got added to the
> task manager?

It has some but not all. For example it doesn't have the dedicated ByteBuffer
and instead continues to use vector<BYTE>.
Also I didn't propagate more elaborate structure management that used std::move
to avoid copying ProcessData. That would require some amount of changes
including replacing the vector of ProcessData with a map and changing all the
code that enumerates over vector<ProcessData> to use map iterators instead.

[stanisc, 2016-09-22 23:55:54]

Description was changed from

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all running Chrome
processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

to

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

[stanisc, 2016-09-22 23:56:37]

Description was changed from

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

to

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

[stanisc, 2016-09-23 00:07:48]

List of changes:
1) Ported a few remaining improvements from TaskManager side
  - Using a dedicated ByteBuffer rather than vector<BYTE>
  - Avoid memory copy when working with data structures (inserting, sorting,
etc).
  - Using a dedicated structure for the snapshot rather than a
vector<ProcessData>
2) Renamed fields in data structures such as ThreadData, ProcessData, Result,
etc to comply with Chrome code styling.
3) Used typedefs for thread ID and process ID instead of HANDLEs used there
before. That should improve readability. 
4) Refactored code moving all the system specific code that takes a snapshot of
data into a separate class. It looks much cleaner this way.

[stanisc, 2016-09-23 01:57:27]

https://codereview.chromium.org/2356753004/diff/60001/tools/win/IdleWakeups/s...
File tools/win/IdleWakeups/system_information_sampler.cpp (right):

https://codereview.chromium.org/2356753004/diff/60001/tools/win/IdleWakeups/s...
tools/win/IdleWakeups/system_information_sampler.cpp:231: return
std::unique_ptr<ProcessDataSnapshot>();
Should fail here rather than return an empty snapshot.

[brucedawson, 2016-09-23 22:10:47]

I think you should include an OWNERS file listing you.
Maybe mention somewhere (CL description?) that this tool was the basis for the
Chrome/Windows Task Manager's idle wakeups column.

This tool has been very helpful for doing browser efficiency comparisons and it
will be good to get this into version control.

https://codereview.chromium.org/2356753004/diff/60001/tools/win/IdleWakeups/s...
File tools/win/IdleWakeups/stdafx.cpp (right):

https://codereview.chromium.org/2356753004/diff/60001/tools/win/IdleWakeups/s...
tools/win/IdleWakeups/stdafx.cpp:8: // and not in this file
Remove TODO paragraph.

[stanisc, 2016-09-23 22:21:42]

Description was changed from

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

to

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

This was used for browsers efficiency comparison - chrome vs. Edge and
Firefox.

Also the tool was used as a basis for prototyping and implementing new
OS_WIN features in Chrome Task Manager including:
- Idle Wakeups column.
- More power/memory efficient implementation of Memory column.

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

[stanisc, 2016-09-23 22:33:16]

Updated the description and added myself to OWNERS file.

https://codereview.chromium.org/2356753004/diff/60001/tools/win/IdleWakeups/s...
File tools/win/IdleWakeups/stdafx.cpp (right):

https://codereview.chromium.org/2356753004/diff/60001/tools/win/IdleWakeups/s...
tools/win/IdleWakeups/stdafx.cpp:8: // and not in this file
On 2016/09/23 22:10:47, brucedawson wrote:
> Remove TODO paragraph.

Done.

[brucedawson, 2016-09-23 22:40:53]

lgtm

[stanisc, 2016-09-24 01:10:03]

The CQ bit was checked by stanisc@chromium.org

[stanisc, 2016-09-24 01:10:04]

The patchset sent to the CQ was uploaded after l-g-t-m from kulshin@chromium.org
Link to the patchset: https://codereview.chromium.org/2356753004/#ps80001
(title: "Removed TODO from stdafx.cpp and added myself to OWNERS file.")

[commit-bot: I haz the power, 2016-09-24 01:10:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 01:38:57]

Description was changed from

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

This was used for browsers efficiency comparison - chrome vs. Edge and
Firefox.

Also the tool was used as a basis for prototyping and implementing new
OS_WIN features in Chrome Task Manager including:
- Idle Wakeups column.
- More power/memory efficient implementation of Memory column.

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

to

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

This was used for browsers efficiency comparison - chrome vs. Edge and
Firefox.

Also the tool was used as a basis for prototyping and implementing new
OS_WIN features in Chrome Task Manager including:
- Idle Wakeups column.
- More power/memory efficient implementation of Memory column.

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

[commit-bot: I haz the power, 2016-09-24 01:38:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-24 01:41:49]

Description was changed from

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified 
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

This was used for browsers efficiency comparison - chrome vs. Edge and
Firefox.

Also the tool was used as a basis for prototyping and implementing new
OS_WIN features in Chrome Task Manager including:
- Idle Wakeups column.
- More power/memory efficient implementation of Memory column.

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.
==========

to

==========
IdleWakeups tool

IdleWakeups is a Windows tool that is designed to measure and
aggregate a few key performance metrics for all specified
browser processes over time. The list of metrics includes:
- Number of running processes
- CPU usage (normalized to one core - 100% meaning one core being
  fully utilized)
- Number of context switches (idle wakeups)
- Private Working Set
- System wide CPU power usage (as reported by Intel Power driver)

The tool supports other browsers (such as Edge or Firefox) based
on partial image name filter (chrome.exe is default)

This was used for browsers efficiency comparison - chrome vs. Edge and
Firefox.

Also the tool was used as a basis for prototyping and implementing new
OS_WIN features in Chrome Task Manager including:
- Idle Wakeups column.
- More power/memory efficient implementation of Memory column.

Sample usage:
- "IdleWakeups.exe" to match all Chrome.exe processes.
- "IdleWakeups.exe" firefox to match Firefox process.
- "IdleWakeups.exe MicrosoftEdge" to match all Edge processes.

When the tool starts it begins gathering and aggregating all metrics
for all matching processes and print results every 2 seconds.

Hit Ctrl+C to stop the measurements and print average and median
values over the entire measurement interval.

Committed: https://crrev.com/a194af037226cf51bca27ccfc9941932e739ba60
Cr-Commit-Position: refs/heads/master@{#420811}
==========

[commit-bot: I haz the power, 2016-09-24 01:41:50]

Patchset 5 (id:??) landed as
https://crrev.com/a194af037226cf51bca27ccfc9941932e739ba60
Cr-Commit-Position: refs/heads/master@{#420811}