Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2356743002:
Prune CreateVisiblePositionDeprecated from FrameSelection (Closed)
|
Created:
4 years, 3 months ago by Xiaocheng Modified:
4 years, 3 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrune CreateVisiblePositionDeprecated from FrameSelection
BUG=647219
Committed: https://crrev.com/a57bb757c45e94590a19cd5353f15664a8db560e
Cr-Commit-Position: refs/heads/master@{#420012}
Patch Set 1 #Patch Set 2 : 201609211524 #Patch Set 3 : Fix compile error #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
xiaochengh@chromium.org changed reviewers: + yosin@chromium.org
PTAL.
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Prune CreateVisiblePositionDeprecated from FrameSelection BUG=647219 ========== to ========== Prune CreateVisiblePositionDeprecated from FrameSelection BUG=647219 Committed: https://crrev.com/a57bb757c45e94590a19cd5353f15664a8db560e Cr-Commit-Position: refs/heads/master@{#420012} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a57bb757c45e94590a19cd5353f15664a8db560e Cr-Commit-Position: refs/heads/master@{#420012} |
