Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2356733002: [turbofan] Fix loop assignment analysis on ForInStatements. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix loop assignment analysis on ForInStatements. The implicit assignment to the induction variable in a ForInStatement has been ignored by the AST loop assignment analysis. This was hidden for cases where the parser introduced a ".for" temporary, but triggers when the variable is declared outside the loop. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-647887 BUG=chromium:647887 Committed: https://crrev.com/4dab7b5a1d6722002d47d0be2481cb65602a2451 Cr-Commit-Position: refs/heads/master@{#39551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/compiler/ast-loop-assignment-analyzer.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-647887.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Starzinger
Benedikt: PTAL. Ben: FYI.
4 years, 3 months ago (2016-09-20 11:43:34 UTC) #4
titzer
lgtm
4 years, 3 months ago (2016-09-20 11:52:23 UTC) #5
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-20 12:28:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356733002/1
4 years, 3 months ago (2016-09-20 12:34:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 12:36:58 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:37:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dab7b5a1d6722002d47d0be2481cb65602a2451
Cr-Commit-Position: refs/heads/master@{#39551}

Powered by Google App Engine
This is Rietveld 408576698