Issue 235673007: Fix deps problems in Jinja template use in build/scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235673007: Fix deps problems in Jinja template use in build/scripts (Closed)

Created:
6 years, 8 months ago by Nils Barth (inactive)

Modified:
6 years, 8 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix deps problems in Jinja template use in build/scripts Three targets are missing correct Jinja template dependencies: * MediaFeatureNames * MediaFeatures * MediaTypeNames This fixes them, so they rebuild properly. Also minor style/order fixes. R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171421

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	Source/build/scripts/make_media_features.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Source/core/core_generated.gyp	View		5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

Hi Adam, Was just playing with build/scripts Jinja usage, and noticed that some targets were ...

6 years, 8 months ago (2014-04-14 01:49:37 UTC) #1

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 8 months ago (2014-04-14 04:21:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/235673007/1

6 years, 8 months ago (2014-04-14 04:22:01 UTC) #4

Message was sent while issue was closed.

Change committed as 171421

Expand Messages | Collapse Messages