Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2356723002: Fix flaky ImeTest#testImeStaysOnLongPressingDifferentNonEmptyInputs (Closed)

Created:
4 years, 3 months ago by yabinh
Modified:
4 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky ImeTest#testImeStaysOnLongPressingDifferentNonEmptyInputs commitText() runs on ImeThread and focusNode() runs on UIThread, which causes a race condition. We should make sure that focusNode() runs after commitText() finished. BUG=628964, 646231 Committed: https://crrev.com/f1522380549d64191081ef505466c43d32816b68 Cr-Commit-Position: refs/heads/master@{#419714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
yabinh
Failure rate (on Nexus 9): 4/20 (before fix) 0/200 (after fix)
4 years, 3 months ago (2016-09-20 08:30:52 UTC) #6
Changwan Ryu
On 2016/09/20 08:30:52, yabinh wrote: > Failure rate (on Nexus 9): > 4/20 (before fix) ...
4 years, 3 months ago (2016-09-20 09:23:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356723002/1
4 years, 3 months ago (2016-09-20 10:08:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 10:12:46 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1522380549d64191081ef505466c43d32816b68 Cr-Commit-Position: refs/heads/master@{#419714}
4 years, 3 months ago (2016-09-20 10:14:33 UTC) #12
aelias_OOO_until_Jul13
4 years, 3 months ago (2016-09-20 21:09:06 UTC) #13
Message was sent while issue was closed.
Thanks!!  Hope those 200 runs were with a script :)

Powered by Google App Engine
This is Rietveld 408576698