Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2356713002: Version 5.5.228.1 (cherry-pick) (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, Yang, oth, v8-merges_googlegroups.com, rmcilroy, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/5.5.228
Project:
v8
Visibility:
Public.

Description

Version 5.5.228.1 (cherry-pick) Merged 298ee9cde1577f2b24969d09032b6fb97e141e5a Revert of [d8] Fix the shared-library build (patchset #12 id:20002 of https://codereview.chromium.org/2342563002/ ) BUG=chromium:646337 LOG=N R=hablich@chromium.org TBR=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/cc39b8ccc1640689f2845b8a3fa71fcea84dbd99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -89 lines) Patch
M BUILD.gn View 4 chunks +11 lines, -3 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/basic-block-profiler.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/d8.h View 12 chunks +22 lines, -0 lines 0 comments Download
M src/d8.cc View 43 chunks +107 lines, -0 lines 0 comments Download
M src/d8.gyp View 2 chunks +12 lines, -8 lines 0 comments Download
M src/factory.h View 3 chunks +10 lines, -8 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -9 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/spaces.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/inspector/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ostreams.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/snapshot/natives.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/utils.h View 4 chunks +4 lines, -7 lines 0 comments Download
M src/v8.gyp View 5 chunks +8 lines, -0 lines 0 comments Download
M src/wasm/wasm-js.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
4 years, 3 months ago (2016-09-20 07:17:32 UTC) #1
Michael Hablich
On 2016/09/20 07:17:32, machenbach (slow) wrote: lgtm
4 years, 3 months ago (2016-09-20 07:18:32 UTC) #2
Michael Achenbach
4 years, 3 months ago (2016-09-20 07:20:13 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cc39b8ccc1640689f2845b8a3fa71fcea84dbd99.

Powered by Google App Engine
This is Rietveld 408576698