Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 23567020: overflow-y: hidden areas can still be scrolled vertically (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: overflow-y: hidden areas can still be scrolled vertically Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 bool autoscrollInProgress() const; 457 bool autoscrollInProgress() const;
458 bool canAutoscroll() const; 458 bool canAutoscroll() const;
459 IntSize calculateAutoscrollDirection(const IntPoint& windowPoint) const; 459 IntSize calculateAutoscrollDirection(const IntPoint& windowPoint) const;
460 static RenderBox* findAutoscrollable(RenderObject*); 460 static RenderBox* findAutoscrollable(RenderObject*);
461 virtual void stopAutoscroll() { } 461 virtual void stopAutoscroll() { }
462 virtual void panScroll(const IntPoint&); 462 virtual void panScroll(const IntPoint&);
463 463
464 bool hasAutoVerticalScrollbar() const { return hasOverflowClip() && (style() ->overflowY() == OAUTO || style()->overflowY() == OOVERLAY); } 464 bool hasAutoVerticalScrollbar() const { return hasOverflowClip() && (style() ->overflowY() == OAUTO || style()->overflowY() == OOVERLAY); }
465 bool hasAutoHorizontalScrollbar() const { return hasOverflowClip() && (style ()->overflowX() == OAUTO || style()->overflowX() == OOVERLAY); } 465 bool hasAutoHorizontalScrollbar() const { return hasOverflowClip() && (style ()->overflowX() == OAUTO || style()->overflowX() == OOVERLAY); }
466 bool scrollsOverflow() const { return scrollsOverflowX() || scrollsOverflowY (); } 466 bool scrollsOverflow() const { return scrollsOverflowX() || scrollsOverflowY (); }
467
468 bool hasScrollableOverflowX() const { return scrollsOverflowX() && scrollWid th() != clientWidth(); }
469 bool hasScrollableOverflowY() const { return scrollsOverflowY() && scrollHei ght() != clientHeight(); }
467 virtual bool scrollsOverflowX() const { return hasOverflowClip() && (style() ->overflowX() == OSCROLL || hasAutoHorizontalScrollbar()); } 470 virtual bool scrollsOverflowX() const { return hasOverflowClip() && (style() ->overflowX() == OSCROLL || hasAutoHorizontalScrollbar()); }
468 virtual bool scrollsOverflowY() const { return hasOverflowClip() && (style() ->overflowY() == OSCROLL || hasAutoVerticalScrollbar()); } 471 virtual bool scrollsOverflowY() const { return hasOverflowClip() && (style() ->overflowY() == OSCROLL || hasAutoVerticalScrollbar()); }
469 bool usesCompositedScrolling() const; 472 bool usesCompositedScrolling() const;
470 473
471 // Elements such as the <input> field override this to specify that they are scrollable 474 // Elements such as the <input> field override this to specify that they are scrollable
472 // outside the context of the CSS overflow style 475 // outside the context of the CSS overflow style
473 virtual bool isIntristicallyScrollable(ScrollbarOrientation orientation) con st { return false; } 476 virtual bool isIntristicallyScrollable(ScrollbarOrientation orientation) con st { return false; }
474 477
475 bool hasUnsplittableScrollingOverflow() const; 478 bool hasUnsplittableScrollingOverflow() const;
476 bool isUnsplittableForPagination() const; 479 bool isUnsplittableForPagination() const;
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 if (UNLIKELY(m_inlineBoxWrapper != 0)) 761 if (UNLIKELY(m_inlineBoxWrapper != 0))
759 deleteLineBoxWrapper(); 762 deleteLineBoxWrapper();
760 } 763 }
761 764
762 m_inlineBoxWrapper = boxWrapper; 765 m_inlineBoxWrapper = boxWrapper;
763 } 766 }
764 767
765 } // namespace WebCore 768 } // namespace WebCore
766 769
767 #endif // RenderBox_h 770 #endif // RenderBox_h
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/autoscroll-overflow-hidden-longhands-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698