Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 23567020: overflow-y: hidden areas can still be scrolled vertically (Closed)

Created:
7 years, 3 months ago by tonikitoo_
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

overflow-y: hidden areas can still be scrolled vertically Previously, if a say div has an overflown content on 'y' but is styled as "overflow-x: auto; overflow-y: hidden", RenderBox::canBeProgramaticallyScrolled would still return true. It interfers, among other things, with the way autoscroll works. Patch fixes it by adding two helper methods to RenderBox class in order to verify a box' scrollability in a given axis (x or y); They are used when checking if a given box is in fact programatically scrollable. Hence RenderBox::canBeScrolledAndHasScrollableArea logic gets hardened. Blink autoscroll behavior now matches Sarafi nightlies, Firefox 23 and Opera12 (pre-blink) in that sense. Patch also adds a test to ensure autoscrolling only happens on a given axis if it is scrollable in that direction, according to its style. Corresponding WebKit revision: https://trac.webkit.org/changeset/154383 BUG=chromium:286345 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157484

Patch Set 1 #

Patch Set 2 : overflow-y: hidden areas can still be scrolled vertically #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
A LayoutTests/fast/events/autoscroll-overflow-hidden-longhands.html View 1 1 chunk +55 lines, -0 lines 0 comments Download
A LayoutTests/fast/events/autoscroll-overflow-hidden-longhands-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
lgtm
7 years, 3 months ago (2013-09-09 19:20:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/23567020/3001
7 years, 3 months ago (2013-09-09 19:20:25 UTC) #2
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=4763
7 years, 3 months ago (2013-09-09 21:17:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/a1.gomes@sisa.samsung.com/23567020/3001
7 years, 3 months ago (2013-09-09 22:41:42 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 23:44:03 UTC) #5
Message was sent while issue was closed.
Change committed as 157484

Powered by Google App Engine
This is Rietveld 408576698