Issue 23567016: Have ScopedStyleResolver deal with ContainerNode references, not pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23567016: Have ScopedStyleResolver deal with ContainerNode references, not pointers (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dglazkov, abarth-chromium

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have ScopedStyleResolver deal with ContainerNode references, not pointers Have ScopedStyleResolver deal with ContainerNode references, not pointers as it can never be NULL. This is now obvious to callers that the ContainerNode cannot be NULL. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157090

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -64 lines)			Patch
M	Source/core/css/resolver/ScopedStyleResolver.h	View	4 chunks	+10 lines, -11 lines	0 comments	Download
M	Source/core/css/resolver/ScopedStyleResolver.cpp	View	13 chunks	+33 lines, -35 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	6 chunks	+14 lines, -11 lines	0 comments	Download
M	Source/core/dom/Element.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/dom/shadow/ShadowRoot.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23567016/1

7 years, 3 months ago (2013-09-02 20:18:14 UTC) #5

Message was sent while issue was closed.

Change committed as 157090

Expand Messages | Collapse Messages