Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 23567002: Assert external strings in external string table. Remove TODOs. (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Assert external strings in external string table. Remove TODOs. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 3 months ago (2013-08-27 09:54:37 UTC) #1
Hannes Payer (out of office)
lgtm
7 years, 3 months ago (2013-08-27 11:52:24 UTC) #2
Yang
7 years, 3 months ago (2013-08-30 07:48:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698