Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2356653003: Finish removing MethodTrampoline (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5661 lines, -5113 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 43 chunks +3388 lines, -3841 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 181 chunks +2273 lines, -1272 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
As before, there are no changes to Parser other than renaming methods.
4 years, 3 months ago (2016-09-20 14:56:32 UTC) #2
scheglov
LGTM Thank you!
4 years, 3 months ago (2016-09-20 15:19:02 UTC) #3
Brian Wilkerson
4 years, 3 months ago (2016-09-20 15:21:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d0245ea2b9a4cdc4bbce73f28f85f73dd90e3d0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698