Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4179)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2356653002: [MD settings] icons for clickable rows (Closed)
Patch Set: review nits Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index a3974fb0383eb454898c9e440a7783f7a5fa8a82..c156f1119087ab28b312346dfcc94db9a029032a 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -5,6 +5,29 @@
<dom-module id="settings-shared">
<template>
<style include="cr-shared-style">
+ button[is='paper-icon-button-light'] {
+ --paper-icon-button-light-ripple: {
+ /* Center the ripple on the icon button. */
+ height: 36px;
+ left: -8px;
+ top: -8px;
+ width: 36px;
+ };
+ -webkit-margin-start: 16px;
+ background-size: cover;
+ flex-shrink: 0;
+ height: 20px;
+ width: 20px;
+ }
+
+ [actionable] button[is="paper-icon-button-light"].icon-arrow-right {
+ background-image: url(images/arrow_right.svg);
+ }
+
+ [actionable] button[is="paper-icon-button-light"].icon-external {
+ background-image: url(images/open_in_new.svg);
+ }
+
/* Use <h2> as the "sub-header" mentioned in the UX design docs. */
h2 {
align-items: center;
@@ -24,6 +47,7 @@
}
paper-button {
+ height: 32px;
margin: 0;
}
@@ -33,7 +57,7 @@
paper-toggle-button {
@apply(--settings-actionable);
- height: 20px;
+ height: var(--settings-row-min-height);
width: 31px;
}
@@ -298,17 +322,27 @@
/* The middle part (horizontally) of a row. */
.settings-box .middle {
- -webkit-margin-start: 16px;
+ -webkit-padding-start: 16px;
align-items: center;
flex: auto;
}
+ .settings-box .middle.two-line {
+ display: flex;
+ min-height: var(--settings-row-two-line-min-height);
+ }
+
/* The start (left in LTR) part (horizontally) of a row. */
.settings-box .start {
align-items: center;
flex: auto;
}
+ .settings-box .start.two-line {
+ display: flex;
+ min-height: var(--settings-row-two-line-min-height);
+ }
+
/* The secondary-action wraps a clickable sub-area of a .settings-box.
* An example is the |sign out| button on the People settings.
* Here is an example with and without a secondary action box:
@@ -320,8 +354,12 @@
* +-------------------------------------------------------+ */
.settings-box .secondary-action {
-webkit-border-start: var(--settings-separator-line);
+ -webkit-margin-start: 20px;
-webkit-padding-start: 20px;
+ align-items: center;
+ display: flex;
flex-shrink: 0;
+ height: var(--settings-row-min-height);
}
.settings-box paper-item iron-icon {
« no previous file with comments | « chrome/browser/resources/settings/settings_resources.grd ('k') | chrome/browser/resources/settings/settings_vars_css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698