[MD settings] icons for clickable rows

chrome/browser/resources/settings/settings_shared_css.html

Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index a3974fb0383eb454898c9e440a7783f7a5fa8a82..dd3324f347f6651a7817c3dfd8c8df60819b2d2c 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -5,6 +5,29 @@
 <dom-module id="settings-shared">
   <template>
     <style include="cr-shared-style">
+      button[is="paper-icon-button-light"] {

[Dan Beam, 2016/09/29 03:19:34]

i'm pretty sure there's a CSS presubmit about using single quotes instead of
double quotes (which the rest of the file does).  can we do that?

[dschuyler, 2016/09/29 21:22:50]

Done.

+        --paper-icon-button-light-ripple: {
+          /* Center the ripple on the icon button. */
+          height: 36px;
+          left: -8px;
+          top: -8px;
+          width: 36px;
+        };
+        -webkit-margin-start: 16px;
+        background-size: cover;
+        flex-shrink: 0;
+        height: 20px;
+        width: 20px;
+      }
+
+      [actionable] button[is="paper-icon-button-light"].icon-arrow-right {
+        background-image: url("images/arrow_right.svg");

[Dan Beam, 2016/09/29 03:19:34]

url(images/arrow_right.svg);

(no quotes)

[dschuyler, 2016/09/29 21:22:50]

Done.

+      }
+
+      [actionable] button[is="paper-icon-button-light"].icon-external {
+        background-image: url("images/open_in_new.svg");
+      }
+
       /* Use <h2> as the "sub-header" mentioned in the UX design docs. */
       h2 {
         align-items: center;
@@ -24,6 +47,7 @@
       }
 
       paper-button {
+        height: 32px;
         margin: 0;
       }
 
@@ -33,7 +57,7 @@
 
       paper-toggle-button {
         @apply(--settings-actionable);
-        height: 20px;
+        height: var(--settings-row-min-height);
         width: 31px;
       }
 
@@ -298,17 +322,27 @@
 
       /* The middle part (horizontally) of a row. */
       .settings-box .middle {
-        -webkit-margin-start: 16px;
+        -webkit-padding-start: 16px;
         align-items: center;
         flex: auto;
       }
 
+      .settings-box .middle.two-line {
+        display: flex;
+        min-height: var(--settings-row-two-line-min-height);
+      }
+
       /* The start (left in LTR) part (horizontally) of a row. */
       .settings-box .start {
         align-items: center;
         flex: auto;
       }
 
+      .settings-box .start.two-line {
+        display: flex;
+        min-height: var(--settings-row-two-line-min-height);
+      }
+
       /* The secondary-action wraps a clickable sub-area of a .settings-box.
        * An example is the |sign out| button on the People settings.
        * Here is an example with and without a secondary action box:
@@ -320,8 +354,12 @@
        *  +-------------------------------------------------------+ */
       .settings-box .secondary-action {
         -webkit-border-start: var(--settings-separator-line);
+        -webkit-margin-start: 20px;
         -webkit-padding-start: 20px;
+        align-items: center;
+        display: flex;
         flex-shrink: 0;
+        height: var(--settings-row-min-height);
       }
 
       .settings-box paper-item iron-icon {