Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2356653002: [MD settings] icons for clickable rows (Closed)
Patch Set: layout adjustment in passwords and site settings Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 353a333458aa03929fbf166bf49124c813ce354e..0d77fab388172c13008cc0fee4f24f5778fab257 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -91,7 +91,10 @@ void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {
void AddA11yStrings(content::WebUIDataSource* html_source) {
LocalizedString localized_strings[] = {
{"a11yPageTitle", IDS_SETTINGS_ACCESSIBILITY},
+ {"a11yWebStore", IDS_SETTINGS_ACCESSIBILITY_WEB_STORE},
{"moreFeaturesLink", IDS_SETTINGS_MORE_FEATURES_LINK},
+ {"moreFeaturesLinkDescription",
+ IDS_SETTINGS_MORE_FEATURES_LINK_DESCRIPTION},
#if defined(OS_CHROMEOS)
{"optionsInMenuLabel", IDS_SETTINGS_OPTIONS_IN_MENU_LABEL},
{"largeMouseCursorLabel", IDS_SETTINGS_LARGE_MOUSE_CURSOR_LABEL},
@@ -153,8 +156,6 @@ void AddA11yStrings(content::WebUIDataSource* html_source) {
IDS_OPTIONS_SETTINGS_ACCESSIBILITY_AUDIO_HEADING},
{"additionalFeaturesTitle",
IDS_OPTIONS_SETTINGS_ACCESSIBILITY_ADDITIONAL_FEATURES_TITLE},
- {"additionalFeaturesDescription",
- IDS_OPTIONS_SETTINGS_ACCESSIBILITY_ADDITIONAL_FEATURES_DESCRIPTION},
hcarmona 2016/09/24 01:55:12 Nit: If this IDS tag is no longer used, should it
dschuyler 2016/09/28 21:03:26 Done.
#endif
};
AddLocalizedStringsBulk(html_source, localized_strings,
@@ -926,7 +927,11 @@ void AddPeopleStrings(content::WebUIDataSource* html_source) {
LocalizedString localized_strings[] = {
{"peoplePageTitle", IDS_SETTINGS_PEOPLE},
{"manageOtherPeople", IDS_SETTINGS_PEOPLE_MANAGE_OTHER_PEOPLE},
+ {"manageOtherPeopleDescription",
+ IDS_SETTINGS_PEOPLE_MANAGE_OTHER_PEOPLE_DESCRIPTION},
Dan Beam 2016/09/24 02:53:59 why are these shuffling?
dschuyler 2016/09/27 00:43:10 They are mostly new strings.
{"manageSupervisedUsers", IDS_SETTINGS_PEOPLE_MANAGE_SUPERVISED_USERS},
+ {"manageSupervisedUsersDescription",
+ IDS_SETTINGS_PEOPLE_MANAGE_SUPERVISED_USERS_DESCRIPTION},
#if defined(OS_CHROMEOS)
{"configurePinChoosePinTitle",
IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_CHOOSE_PIN_TITLE},
@@ -1067,7 +1072,11 @@ void AddPrintingStrings(content::WebUIDataSource* html_source) {
{"printingNotificationsLabel", IDS_SETTINGS_PRINTING_NOTIFICATIONS_LABEL},
{"printingManageCloudPrintDevices",
IDS_SETTINGS_PRINTING_MANAGE_CLOUD_PRINT_DEVICES},
+ {"printingManageCloudPrintDevicesDescription",
+ IDS_SETTINGS_PRINTING_MANAGE_CLOUD_PRINT_DEVICES_DESCRIPTION},
{"cloudPrintersTitle", IDS_SETTINGS_PRINTING_CLOUD_PRINTERS},
+ {"cloudPrintersTitleDescription",
+ IDS_SETTINGS_PRINTING_CLOUD_PRINTERS_DESCRIPTION},
#if defined(OS_CHROMEOS)
{"cupsPrintersTitle", IDS_SETTINGS_PRINTING_CUPS_PRINTERS},
{"addCupsPrinter", IDS_SETTINGS_PRINTING_CUPS_PRINTERS_ADD_PRINTER},
@@ -1152,6 +1161,7 @@ void AddPrivacyStrings(content::WebUIDataSource* html_source) {
{"siteSettings", IDS_SETTINGS_SITE_SETTINGS},
{"siteSettingsDescription", IDS_SETTINGS_SITE_SETTINGS_DESCRIPTION},
{"clearBrowsingData", IDS_SETTINGS_CLEAR_DATA},
+ {"clearBrowsingDataDescription", IDS_SETTINGS_CLEAR_DATA_DESCRIPTION},
{"titleAndCount", IDS_SETTINGS_TITLE_AND_COUNT},
};
AddLocalizedStringsBulk(html_source, localized_strings,
@@ -1185,6 +1195,8 @@ void AddSearchStrings(content::WebUIDataSource* html_source) {
{"searchPageTitle", IDS_SETTINGS_SEARCH},
{"searchExplanation", IDS_SETTINGS_SEARCH_EXPLANATION},
{"searchEnginesManage", IDS_SETTINGS_SEARCH_MANAGE_SEARCH_ENGINES},
+ {"searchEnginesManageDescription",
+ IDS_SETTINGS_SEARCH_MANAGE_SEARCH_ENGINES_DESCRIPTION},
{"searchOkGoogleLabel", IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL},
{"searchOkGoogleLearnMoreLink",
IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK},
@@ -1457,6 +1469,8 @@ void AddSystemStrings(content::WebUIDataSource* html_source) {
{"hardwareAccelerationLabel",
IDS_SETTINGS_SYSTEM_HARDWARE_ACCELERATION_LABEL},
{"changeProxySettings", IDS_SETTINGS_SYSTEM_PROXY_SETTINGS_BUTTON},
+ {"changeProxySettingsDescription",
+ IDS_SETTINGS_SYSTEM_PROXY_SETTINGS_DESCRIPTION},
};
AddLocalizedStringsBulk(html_source, localized_strings,
arraysize(localized_strings));

Powered by Google App Engine
This is Rietveld 408576698