Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2781)

Unified Diff: chrome/browser/resources/settings/system_page/system_page.html

Issue 2356653002: [MD settings] icons for clickable rows (Closed)
Patch Set: layout adjustment in passwords and site settings Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/system_page/system_page.html
diff --git a/chrome/browser/resources/settings/system_page/system_page.html b/chrome/browser/resources/settings/system_page/system_page.html
index 530b7c60927163c0872a251cde047af49ced367c..2faa1ddf3ed7981581489ea85de2ffae3be3c5ad 100644
--- a/chrome/browser/resources/settings/system_page/system_page.html
+++ b/chrome/browser/resources/settings/system_page/system_page.html
@@ -1,5 +1,6 @@
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
<link rel="import" href="/controls/controlled_button.html">
<link rel="import" href="/controls/settings_checkbox.html">
<link rel="import" href="/lifetime_browser_proxy.html">
@@ -37,11 +38,18 @@
</template>
</div>
</div>
- <div class="settings-box">
- <controlled-button class="primary-button" pref="[[prefs.proxy]]"
- on-tap="onChangeProxySettingsTap_">
+ <div class="settings-box two-line" on-tap="onChangeProxySettingsTap_"
+ actionable>
+ <div class="start">
$i18n{changeProxySettings}
+ <div class="secondary">$i18n{changeProxySettingsDescription}</div>
+ </div>
+ <!-- TODO(dschuyler): This controlled-button should be replaced with
+ something that shows the controlled icon without being a button. -->
+ <controlled-button pref="[[prefs.proxy]]">
Dan Beam 2016/09/27 23:03:53 but not these?
dschuyler 2016/09/28 21:03:26 I kept the ones that are not a controlled-button.
</controlled-button>
+ <button class="icon-external" is="paper-icon-button-light">
+ </button>
</div>
</template>
<script src="/system_page/system_page.js"></script>

Powered by Google App Engine
This is Rietveld 408576698