Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2356653002: [MD settings] icons for clickable rows (Closed)
Patch Set: review changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/browser/resources/settings/settings_shared_css.html ('K') | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
2 <link rel="import" href="/icons.html"> 3 <link rel="import" href="/icons.html">
3 <link rel="import" href="/route.html"> 4 <link rel="import" href="/route.html">
4 <link rel="import" href="/settings_shared_css.html"> 5 <link rel="import" href="/settings_shared_css.html">
5 <link rel="import" href="/site_settings/constants.html"> 6 <link rel="import" href="/site_settings/constants.html">
6 <link rel="import" href="/site_settings/site_settings_behavior.html"> 7 <link rel="import" href="/site_settings/site_settings_behavior.html">
7 <link rel="import" href="/site_settings/site_settings_prefs_browser_proxy.html"> 8 <link rel="import" href="/site_settings/site_settings_prefs_browser_proxy.html">
8 9
9 <dom-module id="settings-site-settings-page"> 10 <dom-module id="settings-site-settings-page">
10 <template> 11 <template>
11 <style include="settings-shared"> 12 <style include="settings-shared">
12 .settings-box[category] {
13 @apply(--settings-actionable);
14 }
15 </style> 13 </style>
Dan Beam 2016/09/28 21:56:27 nit: put on one line <style include="settings-sha
dschuyler 2016/09/29 00:40:57 Done.
16 <div class="settings-box first" category$="[[ALL_SITES]]" 14 <div class="settings-box first" category$="[[ALL_SITES]]"
17 on-tap="onTapCategory"> 15 on-tap="onTapCategory" actionable>
18 <iron-icon icon="settings:list"></iron-icon> 16 <iron-icon icon="settings:list"></iron-icon>
19 <div class="middle">$i18n{siteSettingsCategoryAllSites}</div> 17 <div class="middle">$i18n{siteSettingsCategoryAllSites}</div>
18 <button class="icon-arrow-right" is="paper-icon-button-light">
19 </button>
20 </div> 20 </div>
21 <div class="settings-box two-line" 21 <div class="settings-box two-line"
22 category$="[[ContentSettingsTypes.COOKIES]]" on-tap="onTapCategory"> 22 category$="[[ContentSettingsTypes.COOKIES]]" on-tap="onTapCategory"
23 actionable>
23 <iron-icon icon="[[computeIconForContentCategory( 24 <iron-icon icon="[[computeIconForContentCategory(
24 ContentSettingsTypes.COOKIES)]]"></iron-icon> 25 ContentSettingsTypes.COOKIES)]]"></iron-icon>
25 <div class="middle"> 26 <div class="middle">
26 <div> 27 <div>
27 [[computeTitleForContentCategory(ContentSettingsTypes.COOKIES)]] 28 [[computeTitleForContentCategory(ContentSettingsTypes.COOKIES)]]
28 </div> 29 </div>
29 <div id="cookies" class="secondary"></div> 30 <div id="cookies" class="secondary"></div>
30 </div> 31 </div>
32 <button class="icon-arrow-right" is="paper-icon-button-light">
33 </button>
31 </div> 34 </div>
32 <div class="settings-box two-line" 35 <div class="settings-box two-line"
33 category$="[[ContentSettingsTypes.GEOLOCATION]]" on-tap="onTapCategory"> 36 category$="[[ContentSettingsTypes.GEOLOCATION]]" on-tap="onTapCategory"
37 actionable>
34 <iron-icon icon="[[computeIconForContentCategory( 38 <iron-icon icon="[[computeIconForContentCategory(
35 ContentSettingsTypes.GEOLOCATION)]]"></iron-icon> 39 ContentSettingsTypes.GEOLOCATION)]]"></iron-icon>
36 <div class="middle"> 40 <div class="middle">
37 [[computeTitleForContentCategory(ContentSettingsTypes.GEOLOCATION)]] 41 [[computeTitleForContentCategory(ContentSettingsTypes.GEOLOCATION)]]
38 <div id="geolocation" class="secondary"></div> 42 <div id="geolocation" class="secondary"></div>
39 </div> 43 </div>
44 <button class="icon-arrow-right" is="paper-icon-button-light">
45 </button>
40 </div> 46 </div>
41 <div class="settings-box two-line" 47 <div class="settings-box two-line"
42 category$="[[ContentSettingsTypes.CAMERA]]" on-tap="onTapCategory"> 48 category$="[[ContentSettingsTypes.CAMERA]]" on-tap="onTapCategory"
49 actionable>
43 <iron-icon icon="[[computeIconForContentCategory( 50 <iron-icon icon="[[computeIconForContentCategory(
44 ContentSettingsTypes.CAMERA)]]"></iron-icon> 51 ContentSettingsTypes.CAMERA)]]"></iron-icon>
45 <div class="middle"> 52 <div class="middle">
46 [[computeTitleForContentCategory(ContentSettingsTypes.CAMERA)]] 53 [[computeTitleForContentCategory(ContentSettingsTypes.CAMERA)]]
47 <div id="camera" class="secondary"></div> 54 <div id="camera" class="secondary"></div>
48 </div> 55 </div>
56 <button class="icon-arrow-right" is="paper-icon-button-light">
57 </button>
49 </div> 58 </div>
50 <div class="settings-box two-line" category$="[[ContentSettingsTypes.MIC]]" 59 <div class="settings-box two-line" category$="[[ContentSettingsTypes.MIC]]"
51 on-tap="onTapCategory"> 60 on-tap="onTapCategory" actionable>
52 <iron-icon icon="[[computeIconForContentCategory( 61 <iron-icon icon="[[computeIconForContentCategory(
53 ContentSettingsTypes.MIC)]]"></iron-icon> 62 ContentSettingsTypes.MIC)]]"></iron-icon>
54 <div class="middle"> 63 <div class="middle">
55 [[computeTitleForContentCategory(ContentSettingsTypes.MIC)]] 64 [[computeTitleForContentCategory(ContentSettingsTypes.MIC)]]
56 <div id="mic" class="secondary"></div> 65 <div id="mic" class="secondary"></div>
57 </div> 66 </div>
67 <button class="icon-arrow-right" is="paper-icon-button-light">
68 </button>
58 </div> 69 </div>
59 <div class="settings-box two-line" 70 <div class="settings-box two-line"
60 category$="[[ContentSettingsTypes.NOTIFICATIONS]]" 71 category$="[[ContentSettingsTypes.NOTIFICATIONS]]"
61 on-tap="onTapCategory"> 72 on-tap="onTapCategory" actionable>
62 <iron-icon icon="[[computeIconForContentCategory( 73 <iron-icon icon="[[computeIconForContentCategory(
63 ContentSettingsTypes.NOTIFICATIONS)]]"></iron-icon> 74 ContentSettingsTypes.NOTIFICATIONS)]]"></iron-icon>
64 <div class="middle"> 75 <div class="middle">
65 [[computeTitleForContentCategory(ContentSettingsTypes.NOTIFICATIONS)]] 76 [[computeTitleForContentCategory(ContentSettingsTypes.NOTIFICATIONS)]]
66 <div id="notifications" class="secondary"></div> 77 <div id="notifications" class="secondary"></div>
67 </div> 78 </div>
79 <button class="icon-arrow-right" is="paper-icon-button-light">
80 </button>
68 </div> 81 </div>
69 <div class="settings-box two-line" 82 <div class="settings-box two-line"
70 category$="[[ContentSettingsTypes.JAVASCRIPT]]" 83 category$="[[ContentSettingsTypes.JAVASCRIPT]]"
71 on-tap="onTapCategory"> 84 on-tap="onTapCategory" actionable>
72 <iron-icon icon="[[computeIconForContentCategory( 85 <iron-icon icon="[[computeIconForContentCategory(
73 ContentSettingsTypes.JAVASCRIPT)]]"></iron-icon> 86 ContentSettingsTypes.JAVASCRIPT)]]"></iron-icon>
74 <div class="middle"> 87 <div class="middle">
75 [[computeTitleForContentCategory(ContentSettingsTypes.JAVASCRIPT)]] 88 [[computeTitleForContentCategory(ContentSettingsTypes.JAVASCRIPT)]]
76 <div id="javascript" class="secondary"></div> 89 <div id="javascript" class="secondary"></div>
77 </div> 90 </div>
91 <button class="icon-arrow-right" is="paper-icon-button-light">
92 </button>
78 </div> 93 </div>
79 <div class="settings-box two-line" 94 <div class="settings-box two-line"
80 category$="[[ContentSettingsTypes.PLUGINS]]" 95 category$="[[ContentSettingsTypes.PLUGINS]]"
81 on-tap="onTapCategory"> 96 on-tap="onTapCategory" actionable>
82 <iron-icon icon="[[computeIconForContentCategory( 97 <iron-icon icon="[[computeIconForContentCategory(
83 ContentSettingsTypes.PLUGINS)]]"></iron-icon> 98 ContentSettingsTypes.PLUGINS)]]"></iron-icon>
84 <div class="middle"> 99 <div class="middle">
85 [[computeTitleForContentCategory(ContentSettingsTypes.PLUGINS)]] 100 [[computeTitleForContentCategory(ContentSettingsTypes.PLUGINS)]]
86 <div id="plugins" class="secondary"></div> 101 <div id="plugins" class="secondary"></div>
87 </div> 102 </div>
103 <button class="icon-arrow-right" is="paper-icon-button-light">
104 </button>
88 </div> 105 </div>
89 <div class="settings-box two-line" 106 <div class="settings-box two-line"
90 category$="[[ContentSettingsTypes.IMAGES]]" on-tap="onTapCategory"> 107 category$="[[ContentSettingsTypes.IMAGES]]" on-tap="onTapCategory"
108 actionable>
91 <iron-icon icon="[[computeIconForContentCategory( 109 <iron-icon icon="[[computeIconForContentCategory(
92 ContentSettingsTypes.IMAGES)]]"></iron-icon> 110 ContentSettingsTypes.IMAGES)]]"></iron-icon>
93 <div class="middle"> 111 <div class="middle">
94 [[computeTitleForContentCategory(ContentSettingsTypes.IMAGES)]] 112 [[computeTitleForContentCategory(ContentSettingsTypes.IMAGES)]]
95 <div id="images" class="secondary"></div> 113 <div id="images" class="secondary"></div>
96 </div> 114 </div>
115 <button class="icon-arrow-right" is="paper-icon-button-light">
116 </button>
97 </div> 117 </div>
98 <div class="settings-box two-line" 118 <div class="settings-box two-line"
99 category$="[[ContentSettingsTypes.POPUPS]]" on-tap="onTapCategory"> 119 category$="[[ContentSettingsTypes.POPUPS]]" on-tap="onTapCategory"
120 actionable>
100 <iron-icon icon="[[computeIconForContentCategory( 121 <iron-icon icon="[[computeIconForContentCategory(
101 ContentSettingsTypes.POPUPS)]]"></iron-icon> 122 ContentSettingsTypes.POPUPS)]]"></iron-icon>
102 <div class="middle"> 123 <div class="middle">
103 [[computeTitleForContentCategory(ContentSettingsTypes.POPUPS)]] 124 [[computeTitleForContentCategory(ContentSettingsTypes.POPUPS)]]
104 <div id="popups" class="secondary"></div> 125 <div id="popups" class="secondary"></div>
105 </div> 126 </div>
127 <button class="icon-arrow-right" is="paper-icon-button-light">
128 </button>
106 </div> 129 </div>
107 <div class="settings-box two-line" 130 <div class="settings-box two-line"
108 category$="[[ContentSettingsTypes.BACKGROUND_SYNC]]" 131 category$="[[ContentSettingsTypes.BACKGROUND_SYNC]]"
109 on-tap="onTapCategory"> 132 on-tap="onTapCategory" actionable>
110 <iron-icon icon="[[computeIconForContentCategory( 133 <iron-icon icon="[[computeIconForContentCategory(
111 ContentSettingsTypes.BACKGROUND_SYNC)]]"></iron-icon> 134 ContentSettingsTypes.BACKGROUND_SYNC)]]"></iron-icon>
112 <div class="middle"> 135 <div class="middle">
113 [[computeTitleForContentCategory( 136 [[computeTitleForContentCategory(
114 ContentSettingsTypes.BACKGROUND_SYNC)]] 137 ContentSettingsTypes.BACKGROUND_SYNC)]]
115 <div id="backgroundSync" class="secondary"></div> 138 <div id="backgroundSync" class="secondary"></div>
116 </div> 139 </div>
140 <button class="icon-arrow-right" is="paper-icon-button-light">
141 </button>
117 </div> 142 </div>
118 <div class="settings-box two-line" 143 <div class="settings-box two-line"
119 category$="[[ContentSettingsTypes.KEYGEN]]" 144 category$="[[ContentSettingsTypes.KEYGEN]]"
120 on-tap="onTapCategory"> 145 on-tap="onTapCategory" actionable>
121 <iron-icon icon="[[computeIconForContentCategory( 146 <iron-icon icon="[[computeIconForContentCategory(
122 ContentSettingsTypes.KEYGEN)]]"></iron-icon> 147 ContentSettingsTypes.KEYGEN)]]"></iron-icon>
123 <div class="middle"> 148 <div class="middle">
124 [[computeTitleForContentCategory( 149 [[computeTitleForContentCategory(
125 ContentSettingsTypes.KEYGEN)]] 150 ContentSettingsTypes.KEYGEN)]]
126 <div id="keygen" class="secondary"></div> 151 <div id="keygen" class="secondary"></div>
127 </div> 152 </div>
153 <button class="icon-arrow-right" is="paper-icon-button-light">
154 </button>
128 </div> 155 </div>
129 <div class="settings-box two-line" 156 <div class="settings-box two-line"
130 category$="[[ContentSettingsTypes.AUTOMATIC_DOWNLOADS]]" 157 category$="[[ContentSettingsTypes.AUTOMATIC_DOWNLOADS]]"
131 on-tap="onTapCategory"> 158 on-tap="onTapCategory" actionable>
132 <iron-icon icon="[[computeIconForContentCategory( 159 <iron-icon icon="[[computeIconForContentCategory(
133 ContentSettingsTypes.AUTOMATIC_DOWNLOADS)]]"></iron-icon> 160 ContentSettingsTypes.AUTOMATIC_DOWNLOADS)]]"></iron-icon>
134 <div class="middle"> 161 <div class="middle">
135 [[computeTitleForContentCategory( 162 [[computeTitleForContentCategory(
136 ContentSettingsTypes.AUTOMATIC_DOWNLOADS)]] 163 ContentSettingsTypes.AUTOMATIC_DOWNLOADS)]]
137 <div id="automaticDownloads" class="secondary"></div> 164 <div id="automaticDownloads" class="secondary"></div>
138 </div> 165 </div>
166 <button class="icon-arrow-right" is="paper-icon-button-light">
167 </button>
139 </div> 168 </div>
140 <div class="settings-box two-line" 169 <div class="settings-box two-line"
141 category$="[[ContentSettingsTypes.UNSANDBOXED_PLUGINS]]" 170 category$="[[ContentSettingsTypes.UNSANDBOXED_PLUGINS]]"
142 on-tap="onTapCategory"> 171 on-tap="onTapCategory" actionable>
143 <iron-icon icon="[[computeIconForContentCategory( 172 <iron-icon icon="[[computeIconForContentCategory(
144 ContentSettingsTypes.UNSANDBOXED_PLUGINS)]]"></iron-icon> 173 ContentSettingsTypes.UNSANDBOXED_PLUGINS)]]"></iron-icon>
145 <div class="middle"> 174 <div class="middle">
146 [[computeTitleForContentCategory( 175 [[computeTitleForContentCategory(
147 ContentSettingsTypes.UNSANDBOXED_PLUGINS)]] 176 ContentSettingsTypes.UNSANDBOXED_PLUGINS)]]
148 <div id="unsandboxedPlugins" class="secondary"></div> 177 <div id="unsandboxedPlugins" class="secondary"></div>
149 </div> 178 </div>
179 <button class="icon-arrow-right" is="paper-icon-button-light">
180 </button>
150 </div> 181 </div>
151 <div class="settings-box two-line" 182 <div class="settings-box two-line"
152 category$="[[ContentSettingsTypes.PROTOCOL_HANDLERS]]" 183 category$="[[ContentSettingsTypes.PROTOCOL_HANDLERS]]"
153 on-tap="onTapCategory"> 184 on-tap="onTapCategory" actionable>
154 <iron-icon icon="[[computeIconForContentCategory( 185 <iron-icon icon="[[computeIconForContentCategory(
155 ContentSettingsTypes.PROTOCOL_HANDLERS)]]"></iron-icon> 186 ContentSettingsTypes.PROTOCOL_HANDLERS)]]"></iron-icon>
156 <div class="middle"> 187 <div class="middle">
157 [[computeTitleForContentCategory( 188 [[computeTitleForContentCategory(
158 ContentSettingsTypes.PROTOCOL_HANDLERS)]] 189 ContentSettingsTypes.PROTOCOL_HANDLERS)]]
159 <div id="handlers" class="secondary"></div> 190 <div id="handlers" class="secondary"></div>
160 </div> 191 </div>
192 <button class="icon-arrow-right" is="paper-icon-button-light">
193 </button>
161 </div> 194 </div>
162 <div class="settings-box" category$="[[ContentSettingsTypes.ZOOM_LEVELS]]" 195 <div class="settings-box" category$="[[ContentSettingsTypes.ZOOM_LEVELS]]"
163 on-tap="onTapCategory"> 196 on-tap="onTapCategory" actionable>
164 <iron-icon icon="[[computeIconForContentCategory( 197 <iron-icon icon="[[computeIconForContentCategory(
165 ContentSettingsTypes.ZOOM_LEVELS)]]"></iron-icon> 198 ContentSettingsTypes.ZOOM_LEVELS)]]"></iron-icon>
166 <div class="middle"> 199 <div class="middle">
167 [[computeTitleForContentCategory(ContentSettingsTypes.ZOOM_LEVELS)]] 200 [[computeTitleForContentCategory(ContentSettingsTypes.ZOOM_LEVELS)]]
168 </div> 201 </div>
202 <button class="icon-arrow-right" is="paper-icon-button-light">
203 </button>
169 </div> 204 </div>
170 <div class="settings-box" category$="[[ContentSettingsTypes.USB_DEVICES]]" 205 <div class="settings-box" category$="[[ContentSettingsTypes.USB_DEVICES]]"
171 on-tap="onTapCategory"> 206 on-tap="onTapCategory" actionable>
172 <iron-icon icon="[[computeIconForContentCategory( 207 <iron-icon icon="[[computeIconForContentCategory(
173 ContentSettingsTypes.USB_DEVICES)]]"></iron-icon> 208 ContentSettingsTypes.USB_DEVICES)]]"></iron-icon>
174 <div class="middle"> 209 <div class="middle">
175 [[computeTitleForContentCategory(ContentSettingsTypes.USB_DEVICES)]] 210 [[computeTitleForContentCategory(ContentSettingsTypes.USB_DEVICES)]]
176 </div> 211 </div>
212 <button class="icon-arrow-right" is="paper-icon-button-light">
213 </button>
177 </div> 214 </div>
178 </template> 215 </template>
179 <script src="site_settings_page.js"></script> 216 <script src="site_settings_page.js"></script>
180 </dom-module> 217 </dom-module>
OLDNEW
« chrome/browser/resources/settings/settings_shared_css.html ('K') | « chrome/browser/resources/settings/site_settings/site_list.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | third_party/polymer/v1_0/components-chromium/paper-ripple/paper-ripple.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698