[MD settings] icons for clickable rows

chrome/browser/resources/settings/appearance_page/appearance_page.html

 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
 <link rel="import" href="/appearance_page/appearance_browser_proxy.html">
 <link rel="import" href="/controls/controlled_radio_button.html">
 <link rel="import" href="/controls/settings_dropdown_menu.html">
 <link rel="import" href="/controls/settings_input.html">
 <link rel="import" href="/controls/settings_radio_group.html">
 <link rel="import" href="/icons.html">
 <link rel="import" href="/route.html">
 <link rel="import" href="/settings_page/settings_animated_pages.html">
 <link rel="import" href="/settings_page/settings_subpage.html">
 <link rel="import" href="/settings_shared_css.html">
 <link rel="import" href="appearance_fonts_page.html">
 
 <dom-module id="settings-appearance-page">
-  <link rel="import" type="css" href="chrome://resources/css/widgets.css">
   <template>
-    <style include="settings-shared">
-      .settings-box iron-icon {
-        -webkit-margin-end: var(--iron-icon-spacing);

[Dan Beam, 2016/09/28 21:56:27]

why are you removing this?

[dschuyler, 2016/09/29 00:40:57]

It's not needed. Is it needed and I'm missing
where that is?

[Dan Beam, 2016/09/29 03:19:34]

so you're saying this rule didn't have any affect?  it looks like it's matching
<iron-icon> tags inside of class="settings-box" in this file

[dschuyler, 2016/09/29 21:22:50]

I see where that would look wrong. There was an earlier
mistake in that a .start class was used after the iron-icon
rather than a .middle class. The .middle has space before it.
So the icon doesn't need space after it. This change removes
a minor local hack of having a one-off custom css spacing.

[Dan Beam, 2016/09/29 21:45:45]

i see now, thanks for 'splainin

-      }
-    </style>
+    <style include="settings-shared"></style>
     <settings-animated-pages id="pages" section="appearance">
       <neon-animatable route-path="default">
 <if expr="chromeos">
         <div class="settings-box first two-line" id="wallpaperButton"
             on-tap="openWallpaperManager_" actionable
             hidden="[[!pageVisibility.setWallpaper]]">
           <iron-icon icon="settings:wallpaper"></iron-icon>

[Dan Beam, 2016/09/29 03:19:34]

like this

[dschuyler, 2016/09/29 21:22:50]

Acknowledged.

-          <div class="start">
+          <div class="middle">
             <div>$i18n{setWallpaper}</div>
             <div class="secondary">$i18n{openWallpaperApp}</div>
           </div>
+          <button class="icon-external" is="paper-icon-button-light">
+          </button>
         </div>
         <div class="settings-box two-line"
-            hidden="[[!pageVisibility.setTheme]]">
+            hidden="[[!pageVisibility.setTheme]]"
+            on-tap="openThemesGallery_" actionable>
 </if>
 <if expr="not chromeos">
         <div class="settings-box two-line first"
-            hidden="[[!pageVisibility.setTheme]]">
+            hidden="[[!pageVisibility.setTheme]]"
+            on-tap="openThemesGallery_" actionable>
 </if>
-          <div class="layout horizontal center flex"
-              on-tap="openThemesGallery_" actionable>
-            <iron-icon icon="settings:palette"></iron-icon>
-            <div>
-              <div>$i18n{theme}</div>
-              <div class="secondary">[[themeSublabel_]]</div>
-            </div>
+          <iron-icon icon="settings:palette"></iron-icon>

[Dan Beam, 2016/09/28 21:56:26]

are we dropping this now or later?

[dschuyler, 2016/09/29 00:40:57]

I'd like to avoiding adding more to this CL.

+          <div class="middle">
+            <div>$i18n{theme}</div>
+            <div class="secondary">[[themeSublabel_]]</div>
           </div>
+          <button class="icon-external" is="paper-icon-button-light">
+          </button>
           <template is="dom-if" if="[[allowResetTheme_]]">
             <div class="secondary-action">
               <paper-button id="resetTheme" on-tap="resetTheme_"
                   class="secondary-button">
                 $i18n{resetToDefaultTheme}
               </paper-button>
             </div>
           </template>
         </div>
         <div class="settings-box"
@@ skipping 24 matching lines @@
               </controlled-radio-button>
             </settings-radio-group>
           </div>
         </template>
         <div class="settings-box"
             hidden="[[!pageVisibility.bookmarksBar]]">
           <settings-checkbox class="start" label="$i18n{showBookmarksBar}"
               pref="{{prefs.bookmark_bar.show_on_all_tabs}}">
           </settings-checkbox>
         </div>
-        <div class$="settings-box [[getFirst_(
-            pageVisibility.bookmarksBar)]]">
+        <div class$="settings-box [[getFirst_(pageVisibility.bookmarksBar)]]">
 <if expr="is_linux and not chromeos">
           <settings-checkbox class="start" label="$i18n{showWindowDecorations}"
               pref="{{prefs.browser.custom_chrome_frame}}" inverted>
           </settings-checkbox>
         </div>
         <div class="settings-box">
 </if>
           <div class="start">$i18n{fontSize}</div>
           <settings-dropdown-menu id="defaultFontSize"
               pref="{{prefs.webkit.webprefs.default_font_size}}"
               menu-options="[[fontSizeOptions_]]">
           </settings-dropdown-menu>
         </div>
-        <div id="customize-fonts-subpage-trigger"
-            class="settings-box two-line single-column"
+        <div id="customize-fonts-subpage-trigger" class="settings-box two-line"
             on-tap="onCustomizeFontsTap_" actionable>
-          <div>$i18n{customizeFonts}</div>
-          <div class="secondary">$i18n{chooseFonts}</div>
+          <div class="start">
+            <div>$i18n{customizeFonts}</div>
+            <div class="secondary">$i18n{chooseFonts}</div>
+          </div>
+          <button class="icon-arrow-right" is="paper-icon-button-light">
+          </button>
         </div>
         <div class="settings-box"
             hidden="[[!pageVisibility.pageZoom]]">
           <div class="start">$i18n{pageZoom}</div>
           <settings-dropdown-menu id="pageZoom" pref="{{defaultZoomLevel_}}"
               menu-options="[[pageZoomOptions_]]">
           </settings-dropdown-menu>
         </div>
       </neon-animatable>
       <template is="dom-if" route-path="/fonts">
         <settings-subpage
             associated-control="[[$$('#customize-fonts-subpage-trigger')]]"
             page-title="$i18n{customizeFonts}">
           <settings-appearance-fonts-page prefs="{{prefs}}">
           </settings-appearance-fonts-page>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="appearance_page.js"></script>
 </dom-module>